Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 1320443005: [Oilpan] Remove a GC_PLUGIN_IGNORE (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add a comment Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webgl/WebGLRenderingContextBase.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webgl/WebGLRenderingContextBase.cpp
diff --git a/Source/modules/webgl/WebGLRenderingContextBase.cpp b/Source/modules/webgl/WebGLRenderingContextBase.cpp
index 10b30857634a3da6fc0c43b4ec6c3f7d461e5f1e..a9ede5ea3e1fad3f3e31f6e32248d76f964687f0 100644
--- a/Source/modules/webgl/WebGLRenderingContextBase.cpp
+++ b/Source/modules/webgl/WebGLRenderingContextBase.cpp
@@ -1080,6 +1080,9 @@ WebGLRenderingContextBase::~WebGLRenderingContextBase()
m_renderbufferBinding = nullptr;
m_valuebufferBinding = nullptr;
+ // WebGLTexture shared objects will be detached and deleted
+ // m_contextGroup->removeContext(this), which will bring about deleteTexture() calls.
+ // We null these out to avoid accessing those members in deleteTexture().
for (size_t i = 0; i < m_textureUnits.size(); ++i) {
m_textureUnits[i].m_texture2DBinding = nullptr;
m_textureUnits[i].m_textureCubeMapBinding = nullptr;
« no previous file with comments | « Source/modules/webgl/WebGLRenderingContextBase.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698