Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1320433002: Fix for MSAN unintialized value (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : tweak #

Patch Set 3 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/gpu/effects/GrTextureDomain.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
joshualitt
ptal
5 years, 4 months ago (2015-08-25 17:52:55 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/1320433002/diff/1/src/gpu/effects/GrTextureDomain.h File src/gpu/effects/GrTextureDomain.h (right): https://codereview.chromium.org/1320433002/diff/1/src/gpu/effects/GrTextureDomain.h#newcode145 src/gpu/effects/GrTextureDomain.h:145: SkString fDomainName; use kPrevDomainCount here too ?
5 years, 4 months ago (2015-08-25 18:00:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320433002/40001
5 years, 4 months ago (2015-08-25 18:09:16 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 19:10:57 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b5fb5af5734dcc31a5e29212db39f0da71f92f2d

Powered by Google App Engine
This is Rietveld 408576698