Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 132043005: Revert 243967 "Use a Finch Experiment to control the Browser Bla..." (Closed)

Created:
6 years, 11 months ago by Noam Samuel
Modified:
6 years, 11 months ago
Reviewers:
csharp
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 243967 "Use a Finch Experiment to control the Browser Bla..." > Use a Finch Experiment to control the Browser Blacklist > > Also increase the states stored in the register to prevent > the setup code from running multiple times per version if > it fails to start one time. > > BUG=329023 > > Review URL: https://codereview.chromium.org/120963002 TBR=csharp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -379 lines) Patch
M trunk/src/chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/chrome_browser_main_win.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D trunk/src/chrome/browser/chrome_elf_init_unittest_win.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D trunk/src/chrome/browser/chrome_elf_init_win.h View 1 chunk +0 lines, -15 lines 0 comments Download
D trunk/src/chrome/browser/chrome_elf_init_win.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome_elf/blacklist.gypi View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/chrome_elf/blacklist/blacklist.h View 1 chunk +8 lines, -24 lines 0 comments Download
M trunk/src/chrome_elf/blacklist/blacklist.cc View 4 chunks +20 lines, -54 lines 0 comments Download
M trunk/src/chrome_elf/blacklist/test/blacklist_test.cc View 3 chunks +11 lines, -42 lines 0 comments Download
M trunk/src/chrome_elf/chrome_elf.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome_elf/chrome_elf_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Noam Samuel
6 years, 11 months ago (2014-01-10 00:06:53 UTC) #1
Noam Samuel
6 years, 11 months ago (2014-01-10 00:07:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r244026.

Powered by Google App Engine
This is Rietveld 408576698