Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issue 1320423011: Implement SSLConfigService::Observer in QuicStreamFactory (Closed)

Created:
5 years, 3 months ago by Ryan Hamilton
Modified:
5 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement SSLConfigService::Observer in QuicStreamFactory When channel IDs are deleted, QUIC sessions need to be close to avoid reusing the old channel ID. Committed: https://crrev.com/02d87791575f9d90386d32177ad479710c813e90 Cr-Commit-Position: refs/heads/master@{#347868}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M net/quic/quic_stream_factory.h View 3 chunks +7 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 2 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ryan Hamilton
5 years, 3 months ago (2015-09-08 17:30:10 UTC) #2
ramant (doing other things)
lgtm
5 years, 3 months ago (2015-09-08 17:31:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320423011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320423011/40001
5 years, 3 months ago (2015-09-08 22:45:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/110376)
5 years, 3 months ago (2015-09-08 23:57:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320423011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320423011/40001
5 years, 3 months ago (2015-09-09 03:00:05 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-09 09:05:59 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 09:07:06 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/02d87791575f9d90386d32177ad479710c813e90
Cr-Commit-Position: refs/heads/master@{#347868}

Powered by Google App Engine
This is Rietveld 408576698