Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: scripts/slave/recipe_modules/skia/appurify_flavor.py

Issue 1320423005: Skia Appurify bot: write nanobench flags to an asset file (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Move --outResultsFile to recipe Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/skia/fake_specs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/skia/appurify_flavor.py
diff --git a/scripts/slave/recipe_modules/skia/appurify_flavor.py b/scripts/slave/recipe_modules/skia/appurify_flavor.py
index b9d7835246a8cbf50d4d7d65f50a400a742bad32..1a5dee46d6d9064201636bc4c8519530de17f66c 100644
--- a/scripts/slave/recipe_modules/skia/appurify_flavor.py
+++ b/scripts/slave/recipe_modules/skia/appurify_flavor.py
@@ -23,6 +23,8 @@ class AppurifyFlavorUtils(default_flavor.DefaultFlavorUtils):
self.android_bin = self.android_tools.join('bin')
self.apk_dir = self.android_tools.join('apps', 'visualbench', 'build',
'outputs', 'apk')
+ self.assets_dir = self.android_tools.join('apps', 'visualbench', 'src',
+ 'main', 'assets')
self._android_sdk_root = slave_info.android_sdk_root
self._default_env = {'ANDROID_SDK_ROOT': self._android_sdk_root,
'ANDROID_HOME': self._android_sdk_root,
@@ -82,6 +84,13 @@ class AppurifyFlavorUtils(default_flavor.DefaultFlavorUtils):
if ccache:
env['ANDROID_MAKE_CCACHE'] = ccache
+ # Write the nanobench flags to a file inside the APK.
+ args = list(self._skia_api.nanobench_flags)
+ args.extend(['--outResultsFile', '/sdcard/skia_results/visualbench.json'])
+ self.create_clean_host_dir(self.assets_dir)
+ self._skia_api._writefile(self.assets_dir.join('nanobench_flags.txt'),
+ ' '.join(args))
+
cmd = [self.android_bin.join('android_ninja'), target, '-d', self.device]
self._skia_api.run(self._skia_api.m.step, 'build %s' % target, cmd=cmd,
env=env, cwd=self._skia_api.m.path['checkout'])
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/skia/fake_specs.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698