Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1320423005: Skia Appurify bot: write nanobench flags to an asset file (Closed)

Created:
5 years, 3 months ago by borenet
Modified:
5 years, 3 months ago
Reviewers:
rmistry, djsollen
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Skia Appurify bot: write nanobench flags to an asset file BUG=skia:4093 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296529

Patch Set 1 #

Patch Set 2 : No --nocpu/--nogpu flags #

Total comments: 1

Patch Set 3 : Move --outResultsFile to recipe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -20 lines) Patch
M scripts/slave/recipe_modules/skia/appurify_flavor.py View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/skia/fake_specs.py View 1 chunk +32 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.py View 1 chunk +1 line, -0 lines 0 comments Download
A + scripts/slave/recipes/skia/skia.expected/Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Appurify.json View 1 2 13 chunks +73 lines, -20 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Perf-Android-GCC-Nexus5-GPU-Adreno330-Arm7-Release-Appurify.json View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
M scripts/slave/skia/gen_buildbot_specs.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
borenet
https://codereview.chromium.org/1320423005/diff/20001/scripts/slave/recipe_modules/skia/appurify_flavor.py File scripts/slave/recipe_modules/skia/appurify_flavor.py (right): https://codereview.chromium.org/1320423005/diff/20001/scripts/slave/recipe_modules/skia/appurify_flavor.py#newcode90 scripts/slave/recipe_modules/skia/appurify_flavor.py:90: ' '.join(self._skia_api.nanobench_flags)) This puts the nanobench_flags.txt file in the ...
5 years, 3 months ago (2015-08-31 20:20:31 UTC) #2
borenet
Patch set 3 adds the --outResultsFile flag which was removed from the associated CL in ...
5 years, 3 months ago (2015-09-01 14:53:41 UTC) #3
borenet
Friendly ping.
5 years, 3 months ago (2015-09-02 14:51:53 UTC) #4
djsollen
deferring to ravi as I know little about these things.
5 years, 3 months ago (2015-09-02 14:59:21 UTC) #5
rmistry
lgtm
5 years, 3 months ago (2015-09-02 18:38:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320423005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320423005/40001
5 years, 3 months ago (2015-09-02 18:43:56 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 18:46:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296529

Powered by Google App Engine
This is Rietveld 408576698