Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1320403003: Teach mojo_benchmark to control caching conditions. (Closed)

Created:
5 years, 3 months ago by ppi
Modified:
5 years, 3 months ago
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Teach mojo_benchmark to control caching conditions. This patch makes mojo_benchmark run each benchmark twice, first with a flushed cache and again without clearing the cache, yielding cold start and warm start results. This currently supports only flushing the url_response_disk_cache, we will want to clear the network service cache too. R=qsr@google.com Committed: https://chromium.googlesource.com/external/mojo/+/152015f44e134512ba45524e562c7c547b28886d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ben's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M mojo/devtools/common/mojo_benchmark View 1 4 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
ppi
Hi Ben, ptal.
5 years, 3 months ago (2015-09-07 11:00:48 UTC) #2
qsr (NOT THE RIGHT qsr)
https://codereview.chromium.org/1320403003/diff/1/mojo/devtools/common/mojo_benchmark File mojo/devtools/common/mojo_benchmark (right): https://codereview.chromium.org/1320403003/diff/1/mojo/devtools/common/mojo_benchmark#newcode47 mojo/devtools/common/mojo_benchmark:47: _CACHE_SERVICE_URL = 'https://core.mojoapps.io/url_response_disk_cache.mojo' Why both URLs?
5 years, 3 months ago (2015-09-07 11:29:58 UTC) #4
ppi
https://codereview.chromium.org/1320403003/diff/1/mojo/devtools/common/mojo_benchmark File mojo/devtools/common/mojo_benchmark (right): https://codereview.chromium.org/1320403003/diff/1/mojo/devtools/common/mojo_benchmark#newcode47 mojo/devtools/common/mojo_benchmark:47: _CACHE_SERVICE_URL = 'https://core.mojoapps.io/url_response_disk_cache.mojo' On 2015/09/07 11:29:58, qsr (NOT THE ...
5 years, 3 months ago (2015-09-07 11:32:58 UTC) #5
qsr (NOT THE RIGHT qsr)
On 2015/09/07 11:32:58, ppi wrote: > https://codereview.chromium.org/1320403003/diff/1/mojo/devtools/common/mojo_benchmark > File mojo/devtools/common/mojo_benchmark (right): > > https://codereview.chromium.org/1320403003/diff/1/mojo/devtools/common/mojo_benchmark#newcode47 > ...
5 years, 3 months ago (2015-09-07 11:40:28 UTC) #6
qsr (NOT THE RIGHT qsr)
5 years, 3 months ago (2015-09-07 11:40:32 UTC) #7
ppi
Makes sense, done, ptal.
5 years, 3 months ago (2015-09-07 11:48:00 UTC) #8
qsr (NOT THE RIGHT qsr)
lgtm
5 years, 3 months ago (2015-09-07 12:01:10 UTC) #9
ppi
5 years, 3 months ago (2015-09-07 12:05:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
152015f44e134512ba45524e562c7c547b28886d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698