Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 1320363002: [turbofan] Re-wire greedy. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, *Jarin
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Re-wire greedy. We completely un-wired the greedy allocator to focus on the stackchecks in loops (splintering) work. This change re-wires greedy, still behind its flag. For now, enabling the greedy allocator disables the stackchecks in loops feature (and range splintering), so that we are at the baseline we left it at. The main contribution in this change is adapting the codebase after the live range model refactoring, whereby RegisterAllocationData's live_ranges() contains just top-level ranges, and children are accessed via their parents. BUG= Committed: https://crrev.com/71779375adb4a4de86f5f02ba0103769f92b376c Cr-Commit-Position: refs/heads/master@{#30492}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M src/compiler/greedy-allocator.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Mircea Trofin
5 years, 3 months ago (2015-08-31 14:12:21 UTC) #3
Benedikt Meurer
LGTM from my side.
5 years, 3 months ago (2015-08-31 19:19:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320363002/20001
5 years, 3 months ago (2015-08-31 19:31:37 UTC) #7
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from ...
5 years, 3 months ago (2015-08-31 19:31:39 UTC) #9
Jarin
lgtm
5 years, 3 months ago (2015-09-01 04:01:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320363002/20001
5 years, 3 months ago (2015-09-01 04:40:27 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 3 months ago (2015-09-01 04:42:41 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 04:42:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71779375adb4a4de86f5f02ba0103769f92b376c
Cr-Commit-Position: refs/heads/master@{#30492}

Powered by Google App Engine
This is Rietveld 408576698