chrome/browser/android/signin/account_management_screen_helper.h - Issue 132033005: [Android] Stub for account management screen.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/signin/account_management_screen_helper.h

Issue 132033005: [Android] Stub for account management screen. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Grrr. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/android/chrome_jni_registrar.cc ('k') | chrome/browser/android/signin/account_management_screen_helper.cc » ('j') | chrome/browser/signin/signin_header_helper.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_ANDROID_SIGNIN_ACCOUNT_MANAGEMENT_SCREEN_HELPER_H_

	6 #define CHROME_BROWSER_ANDROID_SIGNIN_ACCOUNT_MANAGEMENT_SCREEN_HELPER_H_

	7

	8 #include <jni.h>

	9

	10 #include "base/basictypes.h"

	11

	12 // The glue for Java-side implementation of AccountManagementScreenHelper.

	13 class AccountManagementScreenHelper {

	14 public:

	15 // Registers AccountManagementScreenHelper native methods through JNI.

	16 static bool Register(JNIEnv* env);
	Andrew T Wilson (Slow) 2014/01/16 10:00:45 This is a little odd (defining a class with only s This is a little odd (defining a class with only static methods). Perhaps this should just be in a namespace or something? aruslan 2014/01/16 15:26:13 I haven't found cases of namespace-based implement Show quoted text On 2014/01/16 10:00:45, Andrew T Wilson wrote: > This is a little odd (defining a class with only static methods). Perhaps this > should just be in a namespace or something? I haven't found cases of namespace-based implementations, and it seems to be always implemented through class+statics: http://src.chromium.org/viewvc/chrome/trunk/src/base/android/memory_pressure_... Let me talk with Yaron to find out if anyone cares -- personally I prefer the namespaces. aruslan 2014/01/16 18:37:14 Yaron said it will be slightly inconsistent with t Show quoted text On 2014/01/16 15:26:13, aruslan wrote: > On 2014/01/16 10:00:45, Andrew T Wilson wrote: > > This is a little odd (defining a class with only static methods). Perhaps this > > should just be in a namespace or something? > > I haven't found cases of namespace-based implementations, and it seems to be > always implemented through class+statics: > http://src.chromium.org/viewvc/chrome/trunk/src/base/android/memory_pressure_... > > Let me talk with Yaron to find out if anyone cares -- personally I prefer the > namespaces. Yaron said it will be slightly inconsistent with the rest of the code, but no one really cares. However, I've just realized that class->namespace means that the name becomes underscored_c_style, and that definitely looks weird and inconsistent in the JNI registration code. I would respectfully keep it in a class if you don't mind.
	17

	18 // Opens the account management screen.

	19 static void OpenAccountManagementScreen();

	20

	21 private:

	22 DISALLOW_COPY_AND_ASSIGN(AccountManagementScreenHelper);

	23 };

	24

	25 #endif // CHROME_BROWSER_ANDROID_SIGNIN_ACCOUNT_MANAGEMENT_SCREEN_HELPER_H_

OLD	NEW