Add a test for downloading a file in a new tab multiple times

Add a test for downloading a file in a new tab multiple times

BUG=481758
Committed: https://crrev.com/19fb587ecf290db2b6f3f0db2b59862f6766a4a2
Cr-Commit-Position: refs/heads/master@{#347889}

[Yaron, 2015-09-03 21:25:51]

yfriedman@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Yaron, 2015-09-03 21:25:52]

https://codereview.chromium.org/1320323006/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java
(right):

https://codereview.chromium.org/1320323006/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java:332:
waitForNewTabToStabilize(2);
This seems flaky. I'm not actually getting the confirm infobar when running the
test. So sometimes this isn't able to stabilize.

https://codereview.chromium.org/1320323006/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java:335:
assertPollForInfoBarSize(1);
I've never had this pass. It seems that the infobar isn't triggering.

Is it possible that some dependencies are stubbed out so we don't see the
codepath?

[Changwan Ryu, 2015-09-04 05:26:23]

On 2015/09/03 21:25:52, Yaron wrote:
>
https://codereview.chromium.org/1320323006/diff/20001/chrome/android/javatest...
> File
>
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java
> (right):
> 
>
https://codereview.chromium.org/1320323006/diff/20001/chrome/android/javatest...
>
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java:332:
> waitForNewTabToStabilize(2);
> This seems flaky. I'm not actually getting the confirm infobar when running
the
> test. So sometimes this isn't able to stabilize.
> 
>
https://codereview.chromium.org/1320323006/diff/20001/chrome/android/javatest...
>
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java:335:
> assertPollForInfoBarSize(1);
> I've never had this pass. It seems that the infobar isn't triggering.
> 
> Is it possible that some dependencies are stubbed out so we don't see the
> codepath?

Fixed my mistake which I did while reformatting the CL. Please try again.

[Changwan Ryu, 2015-09-04 08:29:53]

changwan@chromium.org changed reviewers:
+ qinmin@chromium.org

[Changwan Ryu, 2015-09-04 08:31:24]

https://codereview.chromium.org/1320323006/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java
(right):

https://codereview.chromium.org/1320323006/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java:318:
assertTrue(waitForGetDownloadToFinish());
Actually this sometimes fails, probably for the same reason for the other tests
that are marked @FlakyTest.

When it fails, Android download manger does not even start.
Qin, do you have any idea what is causing this?

[Yaron, 2015-09-04 13:30:50]

lgtm

https://codereview.chromium.org/1320323006/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java
(right):

https://codereview.chromium.org/1320323006/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java:274:
// Wait until we have two tabs first. This should be called before checking the
active
This comment seems out of place. Perhaps better in the caller? (or at least
shouldn't refer to specific # of tabs)

[Changwan Ryu, 2015-09-07 01:15:35]

https://codereview.chromium.org/1320323006/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java
(right):

https://codereview.chromium.org/1320323006/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java:274:
// Wait until we have two tabs first. This should be called before checking the
active
On 2015/09/04 13:30:50, Yaron wrote:
> This comment seems out of place. Perhaps better in the caller? (or at least
> shouldn't refer to specific # of tabs)

Done.

[Changwan Ryu, 2015-09-07 01:15:52]

The CQ bit was checked by changwan@chromium.org

[Changwan Ryu, 2015-09-07 01:15:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1320323006/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-09-07 01:15:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320323006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320323006/60001

[commit-bot: I haz the power, 2015-09-07 02:58:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-07 02:58:04]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Changwan Ryu, 2015-09-09 07:21:08]

https://codereview.chromium.org/1320323006/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java
(right):

https://codereview.chromium.org/1320323006/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java:318:
assertTrue(waitForGetDownloadToFinish());
On 2015/09/04 08:31:24, Changwan Ryu wrote:
> Actually this sometimes fails, probably for the same reason for the other
tests
> that are marked @FlakyTest.
> 
> When it fails, Android download manger does not even start.
> Qin, do you have any idea what is causing this?

Actually, DownloadManager abandons download request when Internet connection is
off, even though we are only downloading from a local host. This is probably the
reason for the @FlakyTest labels in this file.

[Changwan Ryu, 2015-09-09 07:21:57]

The CQ bit was checked by changwan@chromium.org

[Changwan Ryu, 2015-09-09 07:21:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1320323006/#ps100001
(title: "fix a failure when internet connection is off")

[commit-bot: I haz the power, 2015-09-09 07:22:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320323006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320323006/100001

[commit-bot: I haz the power, 2015-09-09 09:18:31]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-09-09 09:19:10]

Patchset 6 (id:??) landed as
https://crrev.com/19fb587ecf290db2b6f3f0db2b59862f6766a4a2
Cr-Commit-Position: refs/heads/master@{#347889}