Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1320323004: Make GrTextContext no longer store a GrDrawContext (Closed)

Created:
5 years, 3 months ago by robertphillips
Modified:
5 years, 3 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make GrTextContext no longer store a GrDrawContext This, at least, makes GrTextContexts no longer bound to a single GrDrawContext. (Passing in a RenderTarget and praying it matched the DrawContext was always a bit fishy too). Committed: https://skia.googlesource.com/skia/+/f6703fa0aa98c61b78e2dbd52f610e3c5cd4a4da

Patch Set 1 #

Patch Set 2 : Make GrTextContext no longer store a GrDrawContext #

Patch Set 3 : Fix overlength lines #

Patch Set 4 : Add newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -108 lines) Patch
M src/gpu/GrAtlasTextContext.h View 4 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 16 chunks +29 lines, -29 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 4 chunks +7 lines, -6 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 9 chunks +24 lines, -24 lines 0 comments Download
M src/gpu/GrTextContext.h View 2 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 2 8 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
5 years, 3 months ago (2015-08-31 21:17:17 UTC) #2
bsalomon
On 2015/08/31 21:17:17, robertphillips wrote: Seems like a good step towards decoupling our classes, lgtm
5 years, 3 months ago (2015-09-01 11:57:36 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320323004/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320323004/50001
5 years, 3 months ago (2015-09-01 11:58:43 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 12:03:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320323004/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320323004/50001
5 years, 3 months ago (2015-09-01 12:36:23 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 12:36:51 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:50001) as
https://skia.googlesource.com/skia/+/f6703fa0aa98c61b78e2dbd52f610e3c5cd4a4da

Powered by Google App Engine
This is Rietveld 408576698