Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1320313002: Move makeRange() with VisiblePosition to EditingUtilities.cpp from VisiblePosition.cpp (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move makeRange() with VisiblePosition to EditingUtilities.cpp from VisiblePosition.cpp This patch moves |makeRange()| with |VisiblePosition| to "EditingUtilities.cpp" from "VisiblePosition.cpp" to simplify "VisiblePosition.cpp" for improving code health, since it doesn't depend of implementation of |VisiblePosition| class. BUG=n/a TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201466

Patch Set 1 : 2015-08-31T14:11:43 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M Source/core/editing/EditingUtilities.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-31 05:42:16 UTC) #3
hajimehoshi
lgtm
5 years, 3 months ago (2015-08-31 05:46:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320313002/20001
5 years, 3 months ago (2015-08-31 05:47:24 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 06:21:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201466

Powered by Google App Engine
This is Rietveld 408576698