Issue 1320273004: Revert of Scanline decoding for gifs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1320273004: Revert of Scanline decoding for gifs (Closed)

Created:
5 years, 3 months ago by jcgregorio

Modified:
5 years, 3 months ago

Reviewers:
msarett, scroggo, djsollen

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@real-bmp-scan

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Scanline decoding for gifs (patchset #15 id:380001 of https://codereview.chromium.org/1305123002/ ) Reason for revert: Breaks the build with SkScanlineDecoder.h not found: http://build.chromium.org/p/client.skia/builders/Linux%20Builder/builds/3722/steps/compile/logs/stdio ../../third_party/skia/src/utils/SkBitmapRegionCanvas.h:10:10: fatal error: 'SkScanlineDecoder.h' file not found #include "SkScanlineDecoder.h" Original issue's description: > Scanline decoding for gifs > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/e9c10b9121887e8c300bd41357461418e061984d TBR=scroggo@google.com,djsollen@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/e3330cf2cf361c146af7009301612b4010f82195

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+268 lines, -571 lines)			Patch
M	dm/DMSrcSink.cpp	View	1 chunk	+2 lines, -22 lines	0 comments	Download
M	src/codec/SkCodecPriv.h	View	2 chunks	+1 line, -12 lines	0 comments	Download
M	src/codec/SkCodec_libgif.h	View	5 chunks	+4 lines, -81 lines	0 comments	Download
M	src/codec/SkCodec_libgif.cpp	View	13 chunks	+244 lines, -428 lines	0 comments	Download
M	src/codec/SkScaledCodec.cpp	View	5 chunks	+14 lines, -23 lines	0 comments	Download
M	src/codec/SkScanlineDecoder.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	tests/CodexTest.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320273004/1

5 years, 3 months ago (2015-09-05 17:16:22 UTC) #2

commit-bot: I haz the power

5 years, 3 months ago (2015-09-05 17:16:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e3330cf2cf361c146af7009301612b4010f82195

Expand Messages | Collapse Messages