Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 1320233003: Move character{After,Before}() for VisiblePosition to VisibleUnits.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-01T11:25:07 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisiblePosition.h ('k') | Source/core/editing/VisibleUnits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.cpp
diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp
index 0555c26c42ce29ef1e6ee4d09795280f23552079..b805abab3ed2129c6ae0d2746083b40240b3af0e 100644
--- a/Source/core/editing/VisiblePosition.cpp
+++ b/Source/core/editing/VisiblePosition.cpp
@@ -590,31 +590,6 @@ VisiblePosition visiblePositionOf(const PositionInComposedTree& position, TextAf
return VisiblePosition::createWithoutCanonicalization(PositionWithAffinity(toPositionInDOMTree(canonicalized.position()), canonicalized.affinity()));
}
-UChar32 characterAfter(const VisiblePosition& visiblePosition)
-{
- // We canonicalize to the first of two equivalent candidates, but the second
- // of the two candidates is the one that will be inside the text node
- // containing the character after this visible position.
- Position pos = mostForwardCaretPosition(visiblePosition.deepEquivalent());
- if (!pos.isOffsetInAnchor())
- return 0;
- Node* containerNode = pos.computeContainerNode();
- if (!containerNode || !containerNode->isTextNode())
- return 0;
- unsigned offset = static_cast<unsigned>(pos.offsetInContainerNode());
- Text* textNode = toText(containerNode);
- unsigned length = textNode->length();
- if (offset >= length)
- return 0;
-
- return textNode->data().characterStartingAt(offset);
-}
-
-UChar32 characterBefore(const VisiblePosition& visiblePosition)
-{
- return characterAfter(previousPositionOf(visiblePosition));
-}
-
IntRect absoluteCaretBoundsOf(const VisiblePosition& visiblePosition)
{
LayoutObject* layoutObject;
« no previous file with comments | « Source/core/editing/VisiblePosition.h ('k') | Source/core/editing/VisibleUnits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698