Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Side by Side Diff: Source/core/editing/VisiblePosition.h

Issue 1320233003: Move character{After,Before}() for VisiblePosition to VisibleUnits.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-01T11:25:07 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 int lineDirectionPointForBlockDirectionNavigationOf(const VisiblePosition&); 125 int lineDirectionPointForBlockDirectionNavigationOf(const VisiblePosition&);
126 126
127 // TODO(yosin) We should move |leftPositionOf()| and |rightPositionOf()| to 127 // TODO(yosin) We should move |leftPositionOf()| and |rightPositionOf()| to
128 // "VisibleUnits.cpp". 128 // "VisibleUnits.cpp".
129 VisiblePosition leftPositionOf(const VisiblePosition&); 129 VisiblePosition leftPositionOf(const VisiblePosition&);
130 VisiblePosition rightPositionOf(const VisiblePosition&); 130 VisiblePosition rightPositionOf(const VisiblePosition&);
131 131
132 CORE_EXPORT Position canonicalPositionOf(const Position&); 132 CORE_EXPORT Position canonicalPositionOf(const Position&);
133 CORE_EXPORT PositionInComposedTree canonicalPositionOf(const PositionInComposedT ree&); 133 CORE_EXPORT PositionInComposedTree canonicalPositionOf(const PositionInComposedT ree&);
134 134
135 // TODO(yosin) We should move |characterAfter()| and |characterBefore()| to
136 // "VisibleUnits.cpp"
137 UChar32 characterAfter(const VisiblePosition&);
138 UChar32 characterBefore(const VisiblePosition&);
139
140 // TODO(yosin) We should move |honorEditingBoundaryAtOr{Before,After} to 135 // TODO(yosin) We should move |honorEditingBoundaryAtOr{Before,After} to
141 // "VisibleUnits.cpp" as static function. 136 // "VisibleUnits.cpp" as static function.
142 // next() and previous() will increment/decrement by a character cluster. 137 // next() and previous() will increment/decrement by a character cluster.
143 VisiblePosition honorEditingBoundaryAtOrBefore(const VisiblePosition&, const Pos ition& anchor); 138 VisiblePosition honorEditingBoundaryAtOrBefore(const VisiblePosition&, const Pos ition& anchor);
144 PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionWithAffinity &, const Position& anchor); 139 PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionWithAffinity &, const Position& anchor);
145 PositionInComposedTreeWithAffinity honorEditingBoundaryAtOrBeforeOf(const Positi onInComposedTreeWithAffinity&, const PositionInComposedTree& anchor); 140 PositionInComposedTreeWithAffinity honorEditingBoundaryAtOrBeforeOf(const Positi onInComposedTreeWithAffinity&, const PositionInComposedTree& anchor);
146 VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition&, const Posi tion& anchor); 141 VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition&, const Posi tion& anchor);
147 142
148 CORE_EXPORT VisiblePosition visiblePositionOf(const Position&, TextAffinity = VP _DEFAULT_AFFINITY); 143 CORE_EXPORT VisiblePosition visiblePositionOf(const Position&, TextAffinity = VP _DEFAULT_AFFINITY);
149 CORE_EXPORT VisiblePosition visiblePositionOf(const PositionInComposedTree&, Tex tAffinity = VP_DEFAULT_AFFINITY); 144 CORE_EXPORT VisiblePosition visiblePositionOf(const PositionInComposedTree&, Tex tAffinity = VP_DEFAULT_AFFINITY);
150 145
151 } // namespace blink 146 } // namespace blink
152 147
153 #ifndef NDEBUG 148 #ifndef NDEBUG
154 // Outside the WebCore namespace for ease of invocation from gdb. 149 // Outside the WebCore namespace for ease of invocation from gdb.
155 void showTree(const blink::VisiblePosition*); 150 void showTree(const blink::VisiblePosition*);
156 void showTree(const blink::VisiblePosition&); 151 void showTree(const blink::VisiblePosition&);
157 #endif 152 #endif
158 153
159 #endif // VisiblePosition_h 154 #endif // VisiblePosition_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698