Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1320233002: ipc: Extend attachment broker unit tests. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Extend attachment broker unit tests. Previously, attachment broker unit tests didn't test the full functionality of the receiving side of an IPC channel. This CL adds several new tests, and also extends the functionality being tested. BUG=493414 Committed: https://crrev.com/98daa7355c0dfa401bc92b27f758b55cb0fbeb0f Cr-Commit-Position: refs/heads/master@{#350871}

Patch Set 1 #

Patch Set 2 : Default constructor for HandleWin. #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : Rebase. #

Patch Set 7 : Rebase errors. #

Patch Set 8 : #

Patch Set 9 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -69 lines) Patch
M ipc/BUILD.gn View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 1 2 3 4 5 6 7 8 13 chunks +193 lines, -62 lines 0 comments Download
M ipc/handle_win.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/handle_win.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/ipc.gyp View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/ipc_message_start.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A + ipc/ipc_test_message_generator.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + ipc/ipc_test_message_generator.cc View 1 2 3 4 5 6 1 chunk +6 lines, -6 lines 0 comments Download
A ipc/ipc_test_messages.h View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (16 generated)
erikchen
5 years, 3 months ago (2015-08-29 00:50:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320233002/40001
5 years, 3 months ago (2015-08-29 00:51:25 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/109456) ios_dbg_simulator_ninja on ...
5 years, 3 months ago (2015-08-29 00:58:13 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320233002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320233002/60001
5 years, 3 months ago (2015-08-29 01:03:02 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/126327) ios_dbg_simulator_ninja on ...
5 years, 3 months ago (2015-08-29 01:10:05 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320233002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320233002/80001
5 years, 3 months ago (2015-08-29 01:15:47 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/109468) android_chromium_gn_compile_rel on ...
5 years, 3 months ago (2015-08-29 01:21:04 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320233002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320233002/120001
5 years, 2 months ago (2015-09-24 01:35:32 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/86888)
5 years, 2 months ago (2015-09-24 02:23:28 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320233002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320233002/140001
5 years, 2 months ago (2015-09-24 17:10:50 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/101938) mac_chromium_rel_ng on ...
5 years, 2 months ago (2015-09-24 17:14:14 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320233002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320233002/160001
5 years, 2 months ago (2015-09-24 21:10:21 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/107573)
5 years, 2 months ago (2015-09-24 22:19:21 UTC) #27
erikchen
tsepez: Please review. Note that the tests are still disabled because we haven't yet added ...
5 years, 2 months ago (2015-09-24 23:34:40 UTC) #29
Tom Sepez
lgtm
5 years, 2 months ago (2015-09-25 16:28:41 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320233002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320233002/160001
5 years, 2 months ago (2015-09-25 17:08:40 UTC) #32
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 2 months ago (2015-09-25 18:30:11 UTC) #33
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 18:30:47 UTC) #34
Message was sent while issue was closed. 
Patchset 9 (id:??) landed as
https://crrev.com/98daa7355c0dfa401bc92b27f758b55cb0fbeb0f
Cr-Commit-Position: refs/heads/master@{#350871}

Powered by Google App Engine
This is Rietveld 408576698