Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: runtime/vm/message_handler.cc

Issue 1320223002: Remove invalid assertion. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/message_handler.cc
diff --git a/runtime/vm/message_handler.cc b/runtime/vm/message_handler.cc
index 06b4b602db56329bf45818070c35266c5980b906..f832cbcb1a452de06ef7199da45fa6e94a28ec9f 100644
--- a/runtime/vm/message_handler.cc
+++ b/runtime/vm/message_handler.cc
@@ -320,10 +320,9 @@ void MessageHandler::TaskCallback() {
run_end_callback = true;
}
- // Clear the task_ last. We don't want any other tasks to start up
- // until we are done with all messages and pause notifications.
+ // Clear the task_ last. This allows other tasks to potentially start
+ // for this message handler.
ASSERT(oob_queue_->IsEmpty());
- ASSERT(!ok || queue_->IsEmpty());
task_ = NULL;
}
if (run_end_callback && end_callback_ != NULL) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698