Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1320183003: Preliminary change for new rtc rendering algorithm (Closed)

Created:
5 years, 3 months ago by qiangchen
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preliminary change for new rtc rendering algorithm: 1. Add trace flags for smoothness testing 2. Propagate render_time calculated in Jitter Buffer to media::VideoFrame for new rendering algorithm to use. 3. Move invalidation trigger to compositor thread. This is a recommit of CL 1265433003, the original CL was reverted because it breaks Blink Layout tests and it crashes hangout for HW accelerated RTC. BUG=514873, 525866, 525264 TBR=sunnyps@chromium.org,mcasas@chromium.org,dalecurtis@chromium.org,miu@chromium.org,piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.blink:win_blink_rel Committed: https://crrev.com/20e58fcd6465b008514601b5667390fffb1381fc Cr-Commit-Position: refs/heads/master@{#348025}

Patch Set 1 : From previous commit #

Patch Set 2 : Move Frame Copy To Main Thread #

Patch Set 3 : Consider capture buffer contention #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -140 lines) Patch
M content/renderer/media/video_capture_impl.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 2 4 chunks +72 lines, -32 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 1 2 15 chunks +188 lines, -104 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 5 chunks +21 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M media/base/video_frame.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/video_frame_metadata.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
qiangchen
CL was reverted because it crashes chrome in HW accelerated RTC. I found out the ...
5 years, 3 months ago (2015-08-28 19:54:48 UTC) #2
DaleCurtis
This CL has been reverted 3 times now. I hope you'll take up my suggestion ...
5 years, 3 months ago (2015-09-01 16:36:00 UTC) #3
qiangchen
On 2015/09/01 16:36:00, DaleCurtis wrote: > This CL has been reverted 3 times now. I ...
5 years, 3 months ago (2015-09-01 23:10:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320183003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320183003/40001
5 years, 3 months ago (2015-09-09 20:49:24 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-09 22:20:22 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/20e58fcd6465b008514601b5667390fffb1381fc Cr-Commit-Position: refs/heads/master@{#348025}
5 years, 3 months ago (2015-09-09 22:21:49 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:04:17 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/20e58fcd6465b008514601b5667390fffb1381fc
Cr-Commit-Position: refs/heads/master@{#348025}

Powered by Google App Engine
This is Rietveld 408576698