Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/metrics/actions/actions.xml

Issue 1320153002: Add new termination status for failed launch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review comments. add test. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 4fb51c97b85e6ef6e63143b2ea490ff77aea952e..86ca2e54766065b3288ad84f1b876c63aa63eea2 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -1851,8 +1851,8 @@ should be able to be added at any place in this file.
</action>
<action name="BrowserPlugin.Guest.AbnormalDeath">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>wfh@chromium.org</owner>
+ <description>A renderer process died abnormally.</description>
</action>
<action name="BrowserPlugin.Guest.Attached">
@@ -1861,8 +1861,8 @@ should be able to be added at any place in this file.
</action>
<action name="BrowserPlugin.Guest.Crashed">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>wfh@chromium.org</owner>
+ <description>A renderer process died because it crashed.</description>
</action>
<action name="BrowserPlugin.Guest.Create">
@@ -1886,8 +1886,13 @@ should be able to be added at any place in this file.
</action>
<action name="BrowserPlugin.Guest.Killed">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>wfh@chromium.org</owner>
+ <description>A renderer process died because it was killed.</description>
+</action>
+
+<action name="BrowserPlugin.Guest.LaunchFailed">
+ <owner>wfh@chromium.org</owner>
+ <description>A renderer process failed to launch.</description>
</action>
<action name="BrowserPlugin.Guest.Navigate">

Powered by Google App Engine
This is Rietveld 408576698