content/browser/renderer_host/render_process_host_impl.cc - Issue 1320153002: Add new termination status for failed launch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 1320153002: Add new termination status for failed launch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code review comments. add test. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_process_host_impl.cc

diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc

index f928b0e6861117f64225567260bb3642b641ea95..f0a3dea3d518b782316bdef401367e7487f731c9 100644

--- a/content/browser/renderer_host/render_process_host_impl.cc

+++ b/content/browser/renderer_host/render_process_host_impl.cc

@@ -2392,7 +2392,8 @@ void RenderProcessHostImpl::OnProcessLaunchFailed() {

if (deleting_soon_)

return;

- RendererClosedDetails details { base::TERMINATION_STATUS_PROCESS_WAS_KILLED,

+ // TODO(wfh): Fill in the real error code here see crbug.com/526198.

+ RendererClosedDetails details { base::TERMINATION_STATUS_LAUNCH_FAILED,

-1 };

ProcessDied(true, &details);

}