Add new termination status for failed launch

chromecast/browser/metrics/cast_stability_metrics_provider.cc

Index: chromecast/browser/metrics/cast_stability_metrics_provider.cc
diff --git a/chromecast/browser/metrics/cast_stability_metrics_provider.cc b/chromecast/browser/metrics/cast_stability_metrics_provider.cc
index 96a0f28f5ed610306d63a656d6ad853046cc7bfb..71029b96960aa8aa1fd8c23053b48ca4fe3e1162 100644
--- a/chromecast/browser/metrics/cast_stability_metrics_provider.cc
+++ b/chromecast/browser/metrics/cast_stability_metrics_provider.cc
@@ -27,6 +27,15 @@ namespace metrics {
 
 namespace {
 
+enum RendererType {
+  RENDERER_TYPE_RENDERER,
+  RENDERER_TYPE_EXTENSION,

[jabdelmalek, 2015/09/02 00:39:31]

? i don't see this used, and also this is iin chromecast which doesn't have
extensions afaik

(ah now i see this was copy & paste from some other chrome file, please remove)

[Will Harris, 2015/09/02 20:00:21]

Done.

+  // NOTE: Add new action types only immediately above this line. Also,
+  // make sure the enum list in tools/metrics/histograms/histograms.xml is
+  // updated with any change in here.
+  RENDERER_TYPE_COUNT
+};
+
 void IncrementPrefValue(const char* path) {
   PrefService* pref = shell::CastBrowserProcess::GetInstance()->pref_service();
   DCHECK(pref);
@@ -155,11 +164,16 @@ void CastStabilityMetricsProvider::LogRendererCrash(
 
     UMA_HISTOGRAM_SPARSE_SLOWLY("CrashExitCodes.Renderer",
                                 MapCrashExitCodeForHistogram(exit_code));
-    UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildCrashes", 1);
+    UMA_HISTOGRAM_ENUMERATION("BrowserRenderProcessHost.ChildCrashes",
+                              RENDERER_TYPE_RENDERER, RENDERER_TYPE_COUNT);
   } else if (status == base::TERMINATION_STATUS_PROCESS_WAS_KILLED) {
-    UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildKills", 1);
+    UMA_HISTOGRAM_ENUMERATION("BrowserRenderProcessHost.ChildKills",
+                              RENDERER_TYPE_RENDERER, RENDERER_TYPE_COUNT);
   } else if (status == base::TERMINATION_STATUS_STILL_RUNNING) {
-    UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.DisconnectedAlive", 1);
+    UMA_HISTOGRAM_ENUMERATION("BrowserRenderProcessHost.DisconnectedAlive",
+                              RENDERER_TYPE_RENDERER, RENDERER_TYPE_COUNT);
+  } else if (status == base::TERMINATION_STATUS_LAUNCH_FAILED) {
+    IncrementPrefValue(prefs::kStabilityRendererCrashCount);
   }
 }