Add new termination status for failed launch

chrome/browser/metrics/chrome_stability_metrics_provider.cc

Index: chrome/browser/metrics/chrome_stability_metrics_provider.cc
diff --git a/chrome/browser/metrics/chrome_stability_metrics_provider.cc b/chrome/browser/metrics/chrome_stability_metrics_provider.cc
index a26d263d3f6913906dcaef38f4e92358f05fdc64..e8bdd30fe3c90c9a9c9dd1b03979050edb02c146 100644
--- a/chrome/browser/metrics/chrome_stability_metrics_provider.cc
+++ b/chrome/browser/metrics/chrome_stability_metrics_provider.cc
@@ -14,6 +14,7 @@
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/common/chrome_constants.h"
+#include "chrome/common/chrome_result_codes.h"
 #include "chrome/common/pref_names.h"
 #include "components/metrics/proto/system_profile.pb.h"
 #include "content/public/browser/child_process_data.h"
@@ -66,7 +67,8 @@ int MapCrashExitCodeForHistogram(int exit_code) {
   if (exit_code == STATUS_GUARD_PAGE_VIOLATION)
     return 0x1FCF7EC3;  // Randomly picked number.
 #endif
-
+  if (exit_code == -1)
+    return chrome::RESULT_CODE_RENDERER_PROCESS_START_FAILURE;
   return std::abs(exit_code);
 }
 
@@ -279,7 +281,9 @@ void ChromeStabilityMetricsProvider::LogRendererCrash(
           host->GetID());
 #endif
   if (status == base::TERMINATION_STATUS_PROCESS_CRASHED ||
-      status == base::TERMINATION_STATUS_ABNORMAL_TERMINATION) {
+      status == base::TERMINATION_STATUS_ABNORMAL_TERMINATION ||
+      (status == base::TERMINATION_STATUS_PROCESS_WAS_KILLED &&

[Alexei Svitkine (slow), 2015/08/28 16:45:50]

Probably worth adding a unit test for - e.g. call LogRendererCrash() with given
params and check that a crash is recorded.

[Will Harris, 2015/09/01 01:15:38]

Done.

+       exit_code == -1)) {

[Will Harris, 2015/08/28 16:41:11]

reviewer note: this error code comes from

RenderProcessHostImpl::OnProcessLaunchFailed()

[Alexei Svitkine (slow), 2015/08/28 16:45:50]

Can this be made a constant that both places can refer to?

Is that what you meant to do with RESULT_CODE_RENDERER_PROCESS_START_FAILURE?

[Will Harris, 2015/08/28 16:52:13]

render_process_host_impl.cc is in content so I'd have to make a new content
result code to return this value. These are content/public/common/result_codes.h
and there's not many of them.

I chose to put the result code in chrome/ as it's a "psuedo" resultcode i.e. the
process doesn't actually have a real exit code, it just represents the failure
to start so we can see it on chrome histograms.

tbh not entirely sure what is best here perhaps jam has an opinion as well.

[jam, 2015/08/28 17:18:35]

It seems a pseudo code can be in both modules. Since content already knows about
it, i agree better to have one place for the constant instead of duplicating it.

     if (was_extension_process) {
       IncrementPrefValue(prefs::kStabilityExtensionRendererCrashCount);