Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 1320153002: Add new termination status for failed launch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and a nit. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/process/kill.h ('k') | chrome/browser/metrics/chrome_stability_metrics_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/devtools_ui_bindings.h" 5 #include "chrome/browser/devtools/devtools_ui_bindings.h"
6 6
7 #include "base/json/json_reader.h" 7 #include "base/json/json_reader.h"
8 #include "base/json/json_writer.h" 8 #include "base/json/json_writer.h"
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "base/prefs/scoped_user_pref_update.h" 10 #include "base/prefs/scoped_user_pref_update.h"
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 void DevToolsUIBindings::FrontendWebContentsObserver::RenderProcessGone( 320 void DevToolsUIBindings::FrontendWebContentsObserver::RenderProcessGone(
321 base::TerminationStatus status) { 321 base::TerminationStatus status) {
322 bool crashed = true; 322 bool crashed = true;
323 switch (status) { 323 switch (status) {
324 case base::TERMINATION_STATUS_ABNORMAL_TERMINATION: 324 case base::TERMINATION_STATUS_ABNORMAL_TERMINATION:
325 case base::TERMINATION_STATUS_PROCESS_WAS_KILLED: 325 case base::TERMINATION_STATUS_PROCESS_WAS_KILLED:
326 #if defined(OS_CHROMEOS) 326 #if defined(OS_CHROMEOS)
327 case base::TERMINATION_STATUS_PROCESS_WAS_KILLED_BY_OOM: 327 case base::TERMINATION_STATUS_PROCESS_WAS_KILLED_BY_OOM:
328 #endif 328 #endif
329 case base::TERMINATION_STATUS_PROCESS_CRASHED: 329 case base::TERMINATION_STATUS_PROCESS_CRASHED:
330 case base::TERMINATION_STATUS_LAUNCH_FAILED:
330 if (devtools_bindings_->agent_host_.get()) 331 if (devtools_bindings_->agent_host_.get())
331 devtools_bindings_->Detach(); 332 devtools_bindings_->Detach();
332 break; 333 break;
333 default: 334 default:
334 crashed = false; 335 crashed = false;
335 break; 336 break;
336 } 337 }
337 devtools_bindings_->delegate_->RenderProcessGone(crashed); 338 devtools_bindings_->delegate_->RenderProcessGone(crashed);
338 } 339 }
339 340
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
984 void DevToolsUIBindings::FrontendLoaded() { 985 void DevToolsUIBindings::FrontendLoaded() {
985 if (frontend_loaded_) 986 if (frontend_loaded_)
986 return; 987 return;
987 frontend_loaded_ = true; 988 frontend_loaded_ = true;
988 989
989 // Call delegate first - it seeds importants bit of information. 990 // Call delegate first - it seeds importants bit of information.
990 delegate_->OnLoadCompleted(); 991 delegate_->OnLoadCompleted();
991 992
992 AddDevToolsExtensionsToClient(); 993 AddDevToolsExtensionsToClient();
993 } 994 }
OLDNEW
« no previous file with comments | « base/process/kill.h ('k') | chrome/browser/metrics/chrome_stability_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698