Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 132013003: Android: moves jni_generator samples to use long for JNI. (Closed)

Created:
6 years, 11 months ago by bulach
Modified:
6 years, 11 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Android: moves jni_generator samples to use long for JNI. BUG=317523 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243988

Patch Set 1 #

Patch Set 2 : With fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -39 lines) Patch
M base/android/jni_generator/golden_sample_for_tests_jni.h View 1 6 chunks +14 lines, -14 lines 0 comments Download
M base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java View 5 chunks +9 lines, -9 lines 0 comments Download
M base/android/jni_generator/jni_generator.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/android/jni_generator/jni_generator_tests.py View 1 4 chunks +7 lines, -7 lines 0 comments Download
M base/android/jni_generator/sample_for_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/android/jni_generator/testEagerCalledByNativesOption.golden View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/android/jni_generator/testJNIInitNativeNameOption.golden View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/android/jni_generator/testPureNativeMethodsOption.golden View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bulach
sorry ross, I forgot to update the tests in https://codereview.chromium.org/131543003/, and the change was so ...
6 years, 11 months ago (2014-01-09 16:57:21 UTC) #1
rmcilroy
lgtm
6 years, 11 months ago (2014-01-09 17:03:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/132013003/30001
6 years, 11 months ago (2014-01-09 19:50:08 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 22:00:25 UTC) #4
Message was sent while issue was closed.
Change committed as 243988

Powered by Google App Engine
This is Rietveld 408576698