Replace own callback handling with Promises.

chrome/browser/resources/options/manage_profile_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
 
   /**
    * ManageProfileOverlay class
@@ skipping 49 matching lines @@
 
       $('manage-profile-cancel').onclick =
           $('delete-profile-cancel').onclick = function(event) {
         OptionsPage.closeOverlay();
       };
       $('delete-profile-ok').onclick = function(event) {
         OptionsPage.closeOverlay();
         if (BrowserOptions.getCurrentProfile().isManaged)
           return;
         chrome.send('deleteProfile', [self.profileInfo_.filePath]);
-        options.ManagedUserListData.reloadExistingManagedUsers();
+        options.ManagedUserListData.resetPromise();
       };
       $('add-shortcut-button').onclick = function(event) {
         chrome.send('addProfileShortcut', [self.profileInfo_.filePath]);
       };
       $('remove-shortcut-button').onclick = function(event) {
         chrome.send('removeProfileShortcut', [self.profileInfo_.filePath]);
       };
 
       $('create-profile-managed-signed-in-learn-more-link').onclick =
           function(event) {
@@ skipping 188 matching lines @@
         $(mode + '-profile-ok').disabled = true;
     },
 
     /**
      * Hide the error bubble.
      * @param {string} mode A label that specifies the type of dialog box which
      *     is currently being viewed (i.e. 'create' or 'manage').
      * @private
      */
     hideErrorBubble_: function(mode) {
+      $(mode + '-profile-error-bubble').innerHTML = '';
       $(mode + '-profile-error-bubble').hidden = true;
       $(mode + '-profile-ok').disabled = false;
     },
 
     /**
      * oninput callback for <input> field.
      * @param {string} mode A label that specifies the type of dialog box which
      *     is currently being viewed (i.e. 'create' or 'manage').
      * @private
      */
     onNameChanged_: function(mode) {
       var newName = $(mode + '-profile-name').value;
       var oldName = this.profileInfo_.name;
 
       // In 'create' mode, the initial name can be the name of an already
       // existing supervised user.
       if (newName == oldName && mode == 'manage') {
         this.hideErrorBubble_(mode);
-      } else if (this.profileNames_[newName] != undefined) {
-        var errorHtml =
-            loadTimeData.getString('manageProfilesDuplicateNameError');
-        this.showErrorBubble_(errorHtml, mode, true);
       } else if (mode == 'create' &&
-                 loadTimeData.getBoolean('allowCreateExistingManagedUsers')) {
-        this.checkIfSupervisedUserExists_();
+                 loadTimeData.getBoolean('allowCreateExistingManagedUsers') &&
+                 $('create-profile-managed').checked) {
+        options.ManagedUserListData.requestExistingManagedUsers().then(
+            this.receiveExistingManagedUsers_.bind(this),
+            this.onSigninError_.bind(this));
       } else {
         this.updateOkButton_(mode);
       }
     },
 
     /**
-     * Checks if a supervised user with the currently entered name already
-     * exists.
-     * @private
-     */
-    checkIfSupervisedUserExists_: function() {
-      if (!$('create-profile-managed').checked) {
-        this.updateOkButton_('create');
-        return;
-      }
-      options.ManagedUserListData.requestExistingManagedUsers(
-          this.receiveExistingManagedUsers_.bind(this),
-          this.onSigninError_.bind(this));
-    },
-
-    /**
      * Callback which receives the list of existing managed users. Checks if the
      * currently entered name is the name of an already existing managed user.
      * If yes, the user is prompted to import the existing managed user, and the
      * create button is disabled.
      * @param {Array.<Object>} The list of existing managed users.
      * @private
      */
     receiveExistingManagedUsers_: function(managedUsers) {
       var newName = $('create-profile-name').value;
       var i;
@@ skipping 34 matching lines @@
       this.updateOkButton_('create');
     },
 
     /**
      * Called in case the request for the list of managed users fails because of
      * a signin error.
      * @private
      */
     onSigninError_: function() {
       this.updateImportExistingManagedUserLink_(false);
-      this.updateManagedUsersAllowed_(false);
     },
 
     /**
-     * Called if the name seems to be unused so far.
+     * Called to update the state of the ok button depending if the name is
+     * already used or not.
      * @param {string} mode A label that specifies the type of dialog box which
      *     is currently being viewed (i.e. 'create' or 'manage').
      * @private
      */
     updateOkButton_: function(mode) {
-      this.hideErrorBubble_(mode);
+      var newName = $(mode + '-profile-name').value;
+      if (this.profileNames_[newName] != undefined) {
+        var errorHtml =
+            loadTimeData.getString('manageProfilesDuplicateNameError');
+        this.showErrorBubble_(errorHtml, mode, true);
+      } else {
+        this.hideErrorBubble_(mode);
 
-      var nameIsValid = $(mode + '-profile-name').validity.valid;
-      $(mode + '-profile-ok').disabled = !nameIsValid;
+        var nameIsValid = $(mode + '-profile-name').validity.valid;
+        $(mode + '-profile-ok').disabled = !nameIsValid;
+      }
     },
 
     /**
      * Called when the user clicks "OK" or hits enter. Saves the newly changed
      * profile info.
      * @private
      */
     submitManageChanges_: function() {
       var name = $('manage-profile-name').value;
       var iconURL = $('manage-profile-icon-grid').selectedItem;
 
       chrome.send('setProfileIconAndName',
                   [this.profileInfo_.filePath, iconURL, name]);
+      if (name != this.profileInfo_.name)
+        options.ManagedUserListData.resetPromise();
     },
 
     /**
      * Called when the user clicks "OK" or hits enter. Creates the profile
      * using the information in the dialog.
      * @private
      */
     submitCreateProfile_: function() {
       // This is visual polish: the UI to access this should be disabled for
       // managed users, and the back end will prevent user creation anyway.
@@ skipping 247 matching lines @@
      *       name: "Profile Name",
      *       filePath: "/path/to/profile/data/on/disk"
      *       isManaged: (true|false),
      *     };
      * @private
      */
     onSuccess_: function(profileInfo) {
       this.updateCreateInProgress_(false);
       OptionsPage.closeOverlay();
       if (profileInfo.isManaged) {
-        options.ManagedUserListData.reloadExistingManagedUsers();
+        options.ManagedUserListData.resetPromise();
         profileInfo.custodianEmail = this.signedInEmail_;
         ManagedUserCreateConfirmOverlay.setProfileInfo(profileInfo);
         OptionsPage.showPageByName('managedUserCreateConfirm', false);
         BrowserOptions.updateManagesSupervisedUsers(true);
       }
     },
 
     /**
      * Updates the signed-in or not-signed-in UI when in create mode. Called by
      * the handler in response to the 'requestCreateProfileUpdate' message.
@@ skipping 97 matching lines @@
       return instance[name + '_'].apply(instance, arguments);
     };
   });
 
   // Export
   return {
     ManageProfileOverlay: ManageProfileOverlay,
     CreateProfileOverlay: CreateProfileOverlay,
   };
 });