Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6039)

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

Issue 1320093005: Mac: Don't replace "quotes" with “smartquotes” in the Omnibox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nothing explodes - just set it to 0 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
index f8228b3e7a4b809b77f2a0616300f0ca361b21e9..1d8b1da169c10bd15cf2d4ff8bd393a0c521ee26 100644
--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
@@ -56,13 +56,12 @@ BOOL ThePasteboardIsTooDamnBig() {
forbiddenCharacters_.reset([[NSCharacterSet controlCharacterSet] retain]);
- // These checks seem inappropriate to the omnibox, and also
- // unlikely to work reliably due to our autocomplete interfering.
+ // Disable all substitutions by default. In regular NSTextFields a user may
+ // selectively enable them via context menu, but that submenu is not enabled
+ // for the omnibox. The substitutions are unlikely to be useful in any case.
//
- // Also see <http://crbug.com/173405>.
- NSTextCheckingTypes checkingTypes = [self enabledTextCheckingTypes];
- checkingTypes &= ~NSTextCheckingTypeReplacement;
- checkingTypes &= ~NSTextCheckingTypeCorrection;
+ // Also see http://crbug.com/173405 and http://crbug.com/528014.
+ NSTextCheckingTypes checkingTypes = 0;
[self setEnabledTextCheckingTypes:checkingTypes];
}
return self;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698