Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 132009: fix DOMUI pages after install of .crx (Closed)

Created:
11 years, 6 months ago by rafaelw
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixes issue where dragging a .crx to a chrome:// TabContents, and then navigating to another chrome:// url, the destination DOMUI won't be able to retrieve the data it needs (and thus not function) BUG=14505 R=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19594

Patch Set 1 #

Patch Set 2 : added a comment #

Patch Set 3 : added browsertest #

Patch Set 4 : touch grd to avoid clobber build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -6 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host_manager.cc View 2 chunks +8 lines, -5 lines 0 comments Download
A chrome/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/browser/resources/extensions_ui.html View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rafaelw
11 years, 6 months ago (2009-06-18 04:26:03 UTC) #1
brettw
Is it possible to write a test for this?
11 years, 6 months ago (2009-06-18 05:21:35 UTC) #2
rafaelw
Added browertest
11 years, 5 months ago (2009-06-29 20:49:34 UTC) #3
brettw
11 years, 5 months ago (2009-06-29 21:46:33 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698