Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1320073005: Remove IdleNotification call in the main thread of foreground tab. (Closed)

Created:
5 years, 3 months ago by ulan
Modified:
5 years, 3 months ago
Reviewers:
haraken, rmcilroy
CC:
blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove IdleNotification call in the main thread of foreground tab. V8 posts idle tasks explicitly. BUG=chromium:490559 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M Source/bindings/core/v8/V8Initializer.cpp View 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
Hi Ross, ptal. I will remove IdleNotification in WorkerThread in a separate CL to make ...
5 years, 3 months ago (2015-09-09 10:44:20 UTC) #2
rmcilroy
On 2015/09/09 10:44:20, ulan wrote: > Hi Ross, ptal. lgtm, thanks. > I will remove ...
5 years, 3 months ago (2015-09-09 11:40:59 UTC) #3
haraken
LGTM
5 years, 3 months ago (2015-09-09 11:42:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320073005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320073005/1
5 years, 3 months ago (2015-09-09 11:43:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201977
5 years, 3 months ago (2015-09-09 13:23:03 UTC) #7
ulan
5 years, 3 months ago (2015-09-11 09:24:56 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1336923003/ by ulan@chromium.org.

The reason for reverting is: Reverting because of regression  in
v8.top_25_smooth benchmark (crbug.com/530391).

Powered by Google App Engine
This is Rietveld 408576698