Chromium Code Reviews
Help | Chromium Project | Sign in
(939)

Issue 132004: Add a simple cache of certificates for SSL client authentication.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
eroman
CC:
chromium-reviews_googlegroups.com, rvargas (OOO until 4_21)
Visibility:
Public.

Description

Add a simple cache of certificates for SSL client authentication.
It is based on FtpAuthCache and will be used in similar ways. The
the only difference is that the authentication data is a certificate
rather than username and password.

R=eroman
BUG=http://crbug.com/318
TEST=new unit tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18735

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Fix indentation in http_network_session.h #

Patch Set 4 : Upload before checkin #

Patch Set 5 : Upload before checkin #

Patch Set 6 : Upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -54 lines) Lint Patch
A + net/base/ssl_client_auth_cache.h View 1 2 3 4 1 chunk +27 lines, -33 lines 0 comments 1 errors Download
A + net/base/ssl_client_auth_cache.cc View 1 chunk +10 lines, -19 lines 0 comments 0 errors Download
A net/base/ssl_client_auth_cache_unittest.cc View 1 1 chunk +81 lines, -0 lines 0 comments 1 errors Download
M net/ftp/ftp_auth_cache.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/http/http_network_session.h View 2 4 chunks +6 lines, -1 line 0 comments 0 errors Download
M net/net.gyp View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
wtc
eroman: please review this CL. rvargas: just FYI. No need to review this.
4 years, 10 months ago #1
eroman
4 years, 10 months ago #2
LGTM.

I reckon you could extract the commonality to a templatized class.

But it is small enough that I can tolerate the duplication.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434