Issue 132004: Add a simple cache of certificates for SSL client authentication....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132004: Add a simple cache of certificates for SSL client authentication.... (Closed)

Created:
11 years, 6 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com, rvargas (doing something else)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a simple cache of certificates for SSL client authentication. It is based on FtpAuthCache and will be used in similar ways. The the only difference is that the authentication data is a certificate rather than username and password. R=eroman BUG=http://crbug.com/318 TEST=new unit tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18735

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Fix indentation in http_network_session.h #

Patch Set 4 : Upload before checkin #

Patch Set 5 : Upload before checkin #

Patch Set 6 : Upload before checkin #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -54 lines)			Patch
A +	net/base/ssl_client_auth_cache.h	View	1 2 3 4	1 chunk	+27 lines, -33 lines	0 comments	Download
A +	net/base/ssl_client_auth_cache.cc	View		1 chunk	+10 lines, -19 lines	0 comments	Download
A	net/base/ssl_client_auth_cache_unittest.cc	View	1	1 chunk	+81 lines, -0 lines	0 comments	Download
M	net/ftp/ftp_auth_cache.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_network_session.h	View	2	4 chunks	+6 lines, -1 line	0 comments	Download
M	net/net.gyp	View	1 2 3 4 5	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

eroman: please review this CL. rvargas: just FYI. No need to review this.

11 years, 6 months ago (2009-06-18 01:12:08 UTC) #1

eroman

11 years, 6 months ago (2009-06-18 01:18:54 UTC) #2

LGTM.

I reckon you could extract the commonality to a templatized class.

But it is small enough that I can tolerate the duplication.

Expand Messages | Collapse Messages