Set the fetch API request flags correctly for navigation requests.

Set the fetch API request flags correctly for navigation requests.

Current:
 mode: "no-cors"
 credentials: "same-origin"
 redirect: "follow"

With this patch:
 mode: "same-origin"
 credentials: "include"
 redirect: "manual"

Spec Issue: https://github.com/whatwg/fetch/issues/106
BUG=522873
Committed: https://crrev.com/e43296949e50600ff84c799cf8ae36b455645385
git-svn-id: svn://svn.chromium.org/blink/trunk@202013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[horo, 2015-08-31 07:25:45]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2015-08-31 07:25:45]

falken@
Could you please review this?

[falken, 2015-08-31 09:30:19]

lgtm for sw stuff. My understanding is this change only affects behavior when
you have a service worker and that SW does respondWith(fetch()), is that
correct? It'll need a feature dashboard.

[horo, 2015-09-01 05:04:00]

On 2015/08/31 09:30:19, falken wrote:
> lgtm for sw stuff. My understanding is this change only affects behavior when
> you have a service worker and that SW does respondWith(fetch()), is that
> correct? It'll need a feature dashboard.

Yes.

Added https://www.chromestatus.com/feature/6390594951708672.

[horo, 2015-09-01 05:04:30]

horo@chromium.org changed reviewers:
+ kinuko@chromium.org

[horo, 2015-09-01 05:04:31]

kinuko@
Could you please review this?

[kinuko, 2015-09-01 09:27:43]

lgtm, I think.

[falken, 2015-09-01 09:30:14]

btw core/loader has an OWNERS file, maybe good to get a review from them too?

[horo, 2015-09-02 00:56:13]

horo@chromium.org changed reviewers:
+ japhet@chromium.org

[horo, 2015-09-02 00:56:14]

japhet@
Could you please review Source/core/loader/FrameLoadRequest.h?

[horo, 2015-09-08 07:53:10]

japhet@
Ping?

[Nate Chapin, 2015-09-08 18:09:00]

LGTM, sorry for the delay.

FrameLoadRequest really should use delegated constructors, now that we support
C++11. Would you be willing to make that change, either in this patch or a
separate one?

[horo, 2015-09-09 02:04:35]

On 2015/09/08 18:09:00, Nate Chapin wrote:
> LGTM, sorry for the delay.
> 
> FrameLoadRequest really should use delegated constructors, now that we support
> C++11. Would you be willing to make that change, either in this patch or a
> separate one?

Done.
Uploaded patch set 3.

[horo, 2015-09-09 04:13:19]

Patchset #3 (id:40001) has been deleted

[horo, 2015-09-09 23:18:48]

The CQ bit was checked by horo@chromium.org

[horo, 2015-09-09 23:18:49]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org,
kinuko@chromium.org, japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/1320023005/#ps60001
(title: "delegated constructors")

[commit-bot: I haz the power, 2015-09-09 23:18:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320023005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320023005/60001

[commit-bot: I haz the power, 2015-09-10 00:54:29]

Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202013

[commit-bot: I haz the power, 2015-09-23 12:05:38]

Patchset 3 (id:??) landed as
https://crrev.com/e43296949e50600ff84c799cf8ae36b455645385