Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1320023005: Set the fetch API request flags correctly for navigation requests. (Closed)

Created:
5 years, 3 months ago by horo
Modified:
5 years, 3 months ago
Reviewers:
falken, kinuko, Nate Chapin
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, tyoshino+watch_chromium.org, nhiroki, kinuko+serviceworker, gavinp+loader_chromium.org, horo+watch_chromium.org, kinuko+watch, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Set the fetch API request flags correctly for navigation requests. Current: mode: "no-cors" credentials: "same-origin" redirect: "follow" With this patch: mode: "same-origin" credentials: "include" redirect: "manual" Spec Issue: https://github.com/whatwg/fetch/issues/106 BUG=522873 Committed: https://crrev.com/e43296949e50600ff84c799cf8ae36b455645385 git-svn-id: svn://svn.chromium.org/blink/trunk@202013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : add comments #

Patch Set 3 : delegated constructors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -54 lines) Patch
M LayoutTests/http/tests/serviceworker/fetch-request-fallback.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/navigation-redirect.html View 2 chunks +33 lines, -9 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/request-end-to-end.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/request-end-to-end-worker.js View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/loader/FrameLoadRequest.h View 1 2 2 chunks +28 lines, -44 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
horo
falken@ Could you please review this?
5 years, 3 months ago (2015-08-31 07:25:45 UTC) #2
falken
lgtm for sw stuff. My understanding is this change only affects behavior when you have ...
5 years, 3 months ago (2015-08-31 09:30:19 UTC) #3
horo
On 2015/08/31 09:30:19, falken wrote: > lgtm for sw stuff. My understanding is this change ...
5 years, 3 months ago (2015-09-01 05:04:00 UTC) #4
horo
kinuko@ Could you please review this?
5 years, 3 months ago (2015-09-01 05:04:31 UTC) #6
kinuko
lgtm, I think.
5 years, 3 months ago (2015-09-01 09:27:43 UTC) #7
falken
btw core/loader has an OWNERS file, maybe good to get a review from them too?
5 years, 3 months ago (2015-09-01 09:30:14 UTC) #8
horo
japhet@ Could you please review Source/core/loader/FrameLoadRequest.h?
5 years, 3 months ago (2015-09-02 00:56:14 UTC) #10
horo
japhet@ Ping?
5 years, 3 months ago (2015-09-08 07:53:10 UTC) #11
Nate Chapin
LGTM, sorry for the delay. FrameLoadRequest really should use delegated constructors, now that we support ...
5 years, 3 months ago (2015-09-08 18:09:00 UTC) #12
horo
On 2015/09/08 18:09:00, Nate Chapin wrote: > LGTM, sorry for the delay. > > FrameLoadRequest ...
5 years, 3 months ago (2015-09-09 02:04:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320023005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320023005/60001
5 years, 3 months ago (2015-09-09 23:18:56 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202013
5 years, 3 months ago (2015-09-10 00:54:29 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:05:38 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e43296949e50600ff84c799cf8ae36b455645385

Powered by Google App Engine
This is Rietveld 408576698