Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 1320023003: SitePerProcessBrowserTest: make some tests to use cross_site_iframe_factory (Closed)

Created:
5 years, 3 months ago by ncarter (slow)
Modified:
5 years, 3 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SitePerProcessBrowserTest: make some tests to use cross_site_iframe_factory /cross_site_iframe_factory.html?a(a,a(a,a(a))) gives a page that has the same frame structure as site_per_process_main.html. Add ids to iframe elements so that they work with NavigateIframeToURL Re-enable SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs (which does not fail locally for me) BUG=515672, 465722 Committed: https://crrev.com/4e68f5259e6ed9747bbeec9e4f5dd3767575e949 Cr-Commit-Position: refs/heads/master@{#346222}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -89 lines) Patch
M content/browser/site_per_process_browsertest.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 31 chunks +116 lines, -84 lines 2 comments Download
M content/test/data/cross_site_iframe_factory.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
Charlie: Please have a look. The main motivation of this is to get some working ...
5 years, 3 months ago (2015-08-27 19:28:51 UTC) #2
Charlie Reis
I like it. LGTM. https://codereview.chromium.org/1320023003/diff/1/content/browser/site_per_process_browsertest.cc File content/browser/site_per_process_browsertest.cc (left): https://codereview.chromium.org/1320023003/diff/1/content/browser/site_per_process_browsertest.cc#oldcode1199 content/browser/site_per_process_browsertest.cc:1199: StartFrameAtDataURL(); Nice. I'm not sure ...
5 years, 3 months ago (2015-08-27 21:14:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320023003/1
5 years, 3 months ago (2015-08-28 19:13:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 20:17:13 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 20:18:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e68f5259e6ed9747bbeec9e4f5dd3767575e949
Cr-Commit-Position: refs/heads/master@{#346222}

Powered by Google App Engine
This is Rietveld 408576698