Return const by ref instead of value

Remove const std::string return by std::string.
Cleanup of code.

BUG=

Committed: https://crrev.com/ee2d8cf539b5aa0efc7dbd42f668934909fbcc92
Cr-Commit-Position: refs/heads/master@{#350114}

[tanay.c, 2015-08-31 05:33:36]

tanay.c@samsung.com changed reviewers:
+ stevenjb@chromium.org

[tanay.c, 2015-09-02 05:47:39]

PTAL

[tanay.c, 2015-09-03 05:43:26]

tanay.c@samsung.com changed reviewers:
+ pdr@chromium.org

[tanay.c, 2015-09-03 05:43:27]

PTAL.

[pdr., 2015-09-03 06:23:36]

I'm not the best reviewer for chrome/ changes. To find good reviewers I usually
check the closest OWNERS file to the change. In this case,
chrome/browser/ui/ash/OWNERS, so stevenjb is a good choice.

[stevenjb, 2015-09-09 18:10:45]

https://codereview.chromium.org/1320013006/diff/40001/chrome/browser/ui/ash/s...
File chrome/browser/ui/ash/system_tray_delegate_chromeos.h (right):

https://codereview.chromium.org/1320013006/diff/40001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_delegate_chromeos.h:82: const std::string&
GetEnterpriseDomain() const override;
This shouldn't compile. GetEnterpriseDomain() is is a virtual method that
returns a string. In general, virtual methods shouldn't return references since
a particular implementation might e.g. return a new empty string.

If we actually care about cleaning this up, we should replace 'const string' for
all of these with just 'string' in the ash::SystemTrayDelegate header and all
derived methods.

[tanay.c, 2015-09-21 09:39:35]

On 2015/09/09 18:10:45, stevenjb wrote:
>
https://codereview.chromium.org/1320013006/diff/40001/chrome/browser/ui/ash/s...
> File chrome/browser/ui/ash/system_tray_delegate_chromeos.h (right):
> 
>
https://codereview.chromium.org/1320013006/diff/40001/chrome/browser/ui/ash/s...
> chrome/browser/ui/ash/system_tray_delegate_chromeos.h:82: const std::string&
> GetEnterpriseDomain() const override;
> This shouldn't compile. GetEnterpriseDomain() is is a virtual method that
> returns a string. In general, virtual methods shouldn't return references
since
> a particular implementation might e.g. return a new empty string.
> 
> If we actually care about cleaning this up, we should replace 'const string'
for
> all of these with just 'string' in the ash::SystemTrayDelegate header and all
> derived methods.

Sorry but initially I had checked on the wrong bots. Now removing the const as
requested. 
PTAL.

[stevenjb, 2015-09-21 15:39:56]

lgtm

[tanay.c, 2015-09-22 05:41:55]

The CQ bit was checked by tanay.c@samsung.com

[commit-bot: I haz the power, 2015-09-22 05:42:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320013006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320013006/60001

[commit-bot: I haz the power, 2015-09-22 06:28:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-22 06:28:54]

Patchset 4 (id:??) landed as
https://crrev.com/ee2d8cf539b5aa0efc7dbd42f668934909fbcc92
Cr-Commit-Position: refs/heads/master@{#350114}