Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1320013003: Enable sandbox_linux_unittests on Android (Closed)

Created:
5 years, 3 months ago by jln (very slow on Chromium)
Modified:
5 years, 3 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
ssh://ssh.github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Oops it's Python. #

Total comments: 2

Patch Set 3 : Make SLU unconditional. #

Patch Set 4 : Indent. #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/data/unittests View 1 2 3 4 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jln (very slow on Chromium)
James, would you mind taking a look? As far as I understand the Android try ...
5 years, 3 months ago (2015-08-27 18:41:36 UTC) #2
jamesr
lgtm yes, watching the waterfall sounds good. we keep filing bugs asking for the trybots ...
5 years, 3 months ago (2015-08-27 19:19:34 UTC) #3
jln (very slow on Chromium)
https://chromiumcodereview.appspot.com/1320013003/diff/20001/mojo/tools/data/unittests File mojo/tools/data/unittests (right): https://chromiumcodereview.appspot.com/1320013003/diff/20001/mojo/tools/data/unittests#newcode98 mojo/tools/data/unittests:98: if config.target_os == config.OS_LINUX or config.target_os == config.OS_ANDROID: On ...
5 years, 3 months ago (2015-08-27 20:03:58 UTC) #4
jln (very slow on Chromium)
5 years, 3 months ago (2015-08-27 20:06:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
070703165ed1a246d3366d86a7d2d09eee1155f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698