Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Unified Diff: test/cctest/expression-type-collector-macros.h

Issue 1319983004: Refactor type collector testing macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: merge Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/expression-type-collector-macros.h
diff --git a/test/cctest/expression-type-collector-macros.h b/test/cctest/expression-type-collector-macros.h
index edc1f0911e197984624da1bf436e6736780cb3a7..c049ee3dab891a54d4ceea8d80fe299378f706a3 100644
--- a/test/cctest/expression-type-collector-macros.h
+++ b/test/cctest/expression-type-collector-macros.h
@@ -15,16 +15,13 @@
}
#define DEFAULT_TYPE Bounds::Unbounded()
titzer 2015/08/31 18:08:53 Ok, now I can recommend inlining this macro.
bradn 2015/08/31 18:34:59 Done.
-#define INT32_TYPE \
- Bounds(Type::Signed32(handles.main_zone()), \
- Type::Signed32(handles.main_zone()))
-
-#define CHECK_EXPR(ekind, type) \
- CHECK_LT(index, types.size()); \
- CHECK(strcmp(#ekind, types[index].kind) == 0); \
- CHECK_EQ(depth, types[index].depth); \
- CHECK(type.lower->Is(types[index].bounds.lower)); \
- CHECK(type.upper->Is(types[index].bounds.upper)); \
+
+
+#define CHECK_EXPR(ekind, type) \
+ CHECK_LT(index, types.size()); \
+ CHECK(strcmp(#ekind, types[index].kind) == 0); \
+ CHECK_EQ(depth, types[index].depth); \
+ CHECK(types[index].bounds.Narrows(type)); \
for (int j = (++depth, ++index, 0); j < 1 ? 1 : (--depth, 0); ++j)
#define CHECK_VAR(vname, type) \
@@ -33,4 +30,12 @@
types[index - 1].name->raw_data() + \
types[index - 1].name->byte_length()));
+#define CHECK_SKIP() \
+ { \
+ ++index; \
+ while (index < types.size() && types[index].depth > depth) { \
+ ++index; \
+ } \
+ }
+
#endif // V8_EXPRESSION_TYPE_COLLECTOR_MACROS_H_
« no previous file with comments | « no previous file | test/cctest/test-ast-expression-visitor.cc » ('j') | test/cctest/test-ast-expression-visitor.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698