Refactor type collector testing macros.

Refactor type collector testing macros.

Assume a zone is in scope instead of a handles object.
Move INT32_TYPE into test-typing-reset.
Provide a CHECK_SKIP() macro to allow skipping
sections of an ast expression walk.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-typing-reset, test-ast-expression-visitor
R=rossberg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/ffa5e5fc3972eed63d477e09752abde69d6ad0b1
Cr-Commit-Position: refs/heads/master@{#30484}

[bradn, 2015-08-30 06:32:24]

Patchset #1 (id:1) has been deleted

[titzer, 2015-08-31 09:54:42]

https://codereview.chromium.org/1319983004/diff/20001/test/cctest/expression-...
File test/cctest/expression-type-collector-macros.h (right):

https://codereview.chromium.org/1319983004/diff/20001/test/cctest/expression-...
test/cctest/expression-type-collector-macros.h:17: #define DEFAULT_TYPE
Bounds::Unbounded(zone)
I think the zone would be unnecessary if we had a Bounds::Unbounded() that
doesn't take one, which seems possible since both Type::Any() and Type::None()
work without a zone.

[bradn, 2015-08-31 18:05:29]

PTAL

https://codereview.chromium.org/1319983004/diff/20001/test/cctest/expression-...
File test/cctest/expression-type-collector-macros.h (right):

https://codereview.chromium.org/1319983004/diff/20001/test/cctest/expression-...
test/cctest/expression-type-collector-macros.h:17: #define DEFAULT_TYPE
Bounds::Unbounded(zone)
On 2015/08/31 09:54:42, titzer wrote:
> I think the zone would be unnecessary if we had a Bounds::Unbounded() that
> doesn't take one, which seems possible since both Type::Any() and Type::None()
> work without a zone.

Done in other CL

[titzer, 2015-08-31 18:08:54]

https://codereview.chromium.org/1319983004/diff/40001/test/cctest/expression-...
File test/cctest/expression-type-collector-macros.h (right):

https://codereview.chromium.org/1319983004/diff/40001/test/cctest/expression-...
test/cctest/expression-type-collector-macros.h:17: #define DEFAULT_TYPE
Bounds::Unbounded()
Ok, now I can recommend inlining this macro.

https://codereview.chromium.org/1319983004/diff/40001/test/cctest/test-ast-ex...
File test/cctest/test-ast-expression-visitor.cc (right):

https://codereview.chromium.org/1319983004/diff/40001/test/cctest/test-ast-ex...
test/cctest/test-ast-expression-visitor.cc:55: ZoneVector<ExpressionTypeEntry>
types(zone);
You can put this subexpression back in now. (and below).

[bradn, 2015-08-31 18:34:59]

PTAL

https://codereview.chromium.org/1319983004/diff/40001/test/cctest/expression-...
File test/cctest/expression-type-collector-macros.h (right):

https://codereview.chromium.org/1319983004/diff/40001/test/cctest/expression-...
test/cctest/expression-type-collector-macros.h:17: #define DEFAULT_TYPE
Bounds::Unbounded()
On 2015/08/31 18:08:53, titzer wrote:
> Ok, now I can recommend inlining this macro.

Done.

https://codereview.chromium.org/1319983004/diff/40001/test/cctest/test-ast-ex...
File test/cctest/test-ast-expression-visitor.cc (right):

https://codereview.chromium.org/1319983004/diff/40001/test/cctest/test-ast-ex...
test/cctest/test-ast-expression-visitor.cc:55: ZoneVector<ExpressionTypeEntry>
types(zone);
On 2015/08/31 18:08:53, titzer wrote:
> You can put this subexpression back in now. (and below).

Done.

[titzer, 2015-08-31 19:15:11]

lgtm

[bradn, 2015-08-31 19:15:21]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2015-08-31 19:15:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1319983004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1319983004/80001

[commit-bot: I haz the power, 2015-08-31 19:16:57]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-08-31 19:17:16]

Patchset 4 (id:??) landed as
https://crrev.com/ffa5e5fc3972eed63d477e09752abde69d6ad0b1
Cr-Commit-Position: refs/heads/master@{#30484}