chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h - Issue 1319983002: Add a top shadow to material design omnibox dropdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h

Issue 1319983002: Add a top shadow to material design omnibox dropdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: new comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h

diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h

index 376f2f57a91570126cd9ef4f66684c5d2ff98510..2ca5c2c56636416fe1ee628481e651bb7cd11477 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h

+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h

@@ -156,7 +156,9 @@ class OmniboxPopupContentsView : public views::View,

int start_margin_;

int end_margin_;

- const gfx::ImageSkia* bottom_shadow_; // Ptr owned by resource bundle.

+ // These pointers are owned by the resource bundle.

+ const gfx::ImageSkia* top_shadow_;

+ const gfx::ImageSkia* bottom_shadow_;

// When the dropdown is not wide enough while displaying postfix suggestions,

// we use the width of widest match contents to shift the suggestions so that