Add a top shadow to material design omnibox dropdown

chrome/browser/ui/views/location_bar/location_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/i18n/rtl.h"
@@ skipping 470 matching lines @@
 int LocationBarView::GetInternalHeight(bool use_preferred_size) {
   int total_height =
       use_preferred_size ? GetPreferredSize().height() : height();
   return std::max(total_height - (VerticalPadding() * 2), 0);
 }
 
 void LocationBarView::GetOmniboxPopupPositioningInfo(
     gfx::Point* top_left_screen_coord,
     int* popup_width,
     int* left_margin,
-    int* right_margin) {
+    int* right_margin,
+    int top_edge_overlap) {
   // Because the popup might appear atop the attached bookmark bar, there won't
   // necessarily be a client edge separating it from the rest of the toolbar.
   // Therefore we position the popup high enough so it can draw its own client
   // edge at the top, in the same place the toolbar would normally draw the
   // client edge.

[Peter Kasting, 2015/08/29 01:00:23]

Let's remove this comment from this file, as it basically is about why the
overlap has the value it has, which is something this callee doesn't need or
care to know.  This info belongs more properly in the caller; I'll give thoughts
there about how to convey this.

[tdanderson, 2015/08/31 15:23:18]

Done.

-  *top_left_screen_coord = gfx::Point(
-      0,
-      parent()->height() - views::NonClientFrameView::kClientEdgeThickness);
+  *top_left_screen_coord = gfx::Point(0, parent()->height() - top_edge_overlap);
+
   views::View::ConvertPointToScreen(parent(), top_left_screen_coord);
   *popup_width = parent()->width();
 
   gfx::Rect location_bar_bounds(bounds());
   location_bar_bounds.Inset(kNormalEdgeThickness, 0);
   *left_margin = location_bar_bounds.x();
   *right_margin = *popup_width - location_bar_bounds.right();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
@@ skipping 899 matching lines @@
 
 void LocationBarView::ModelChanged(const SearchModel::State& old_state,
                                    const SearchModel::State& new_state) {
   const bool visible = !GetToolbarModel()->input_in_progress() &&
       new_state.voice_search_supported;
   if (mic_search_view_->visible() != visible) {
     mic_search_view_->SetVisible(visible);
     Layout();
   }
 }