Add a top shadow to material design omnibox dropdown

chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_POPUP_CONTENTS_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_POPUP_CONTENTS_VIEW_H_
 
 #include "base/memory/weak_ptr.h"
 #include "components/omnibox/browser/omnibox_popup_model.h"
 #include "components/omnibox/browser/omnibox_popup_view.h"
@@ skipping 138 matching lines @@
 
   // The popup sizes vertically using an animation when the popup is getting
   // shorter (not larger, that makes it look "slow").
   gfx::SlideAnimation size_animation_;
   gfx::Rect start_bounds_;
   gfx::Rect target_bounds_;
 
   int start_margin_;
   int end_margin_;
 
   const gfx::ImageSkia* bottom_shadow_;  // Ptr owned by resource bundle.

[Peter Kasting, 2015/08/27 19:05:04]

Nit: Since there are now two of these, just write "These pointers are owned by
the resource bundle." in a comment above the two.

[tdanderson, 2015/08/27 19:47:20]

Done.

+  const gfx::ImageSkia* top_shadow_;     // Ptr owned by resource bundle.

[Peter Kasting, 2015/08/27 19:05:04]

Tiny nit: Reverse these (and in the .cc file) since we logically think about
things top-to-bottom.

[tdanderson, 2015/08/27 19:47:20]

Done.

 
   // When the dropdown is not wide enough while displaying postfix suggestions,
   // we use the width of widest match contents to shift the suggestions so that
   // the widest suggestion just reaches the end edge.
   int max_match_contents_width_;
 
   DISALLOW_COPY_AND_ASSIGN(OmniboxPopupContentsView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_POPUP_CONTENTS_VIEW_H_