Issue 1319973011: Stack sampling profiler uses uintptr_t instead of void*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1319973011: Stack sampling profiler uses uintptr_t instead of void*. (Closed)

Created:
5 years, 3 months ago by sydli

Modified:
5 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@UMA2_refactor

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Stack sampling profiler uses uintptr_t instead of void*. This CL alters the stack sampling profiler's use of void* to uintptr_t. This allows 1) sampled stacks to be sent via IPC and 2) a better high-level representation of an address from a different process. BUG=517958

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -40 lines)			Patch
M	base/profiler/stack_sampling_profiler.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	base/profiler/stack_sampling_profiler.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	components/metrics/call_stack_profile_metrics_provider_unittest.cc	View	16 chunks	+33 lines, -33 lines	0 comments	Download

Depends on Patchset:

Issue 1318733007 Patch 90001

Dependent Patchsets:

Issue 1325653003 Patch 20001