Issue 1319953003: [heap] Get rid of dead code in HeapIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1319953003: [heap] Get rid of dead code in HeapIterator. (Closed)

Created:
5 years, 3 months ago by Michael Lippautz

Modified:
5 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[heap] Get rid of dead code in HeapIterator. BUG= Committed: https://crrev.com/5d3f801a463df6644e26f709db691d44469643c8 Cr-Commit-Position: refs/heads/master@{#30418}

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -43 lines)			Patch
	M	src/heap/heap.h	View	1	1 chunk	+7 lines, -7 lines	0 comments	Download
	M	src/heap/heap.cc	View		3 chunks	+11 lines, -36 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Lippautz

Small cleanup (dead code; adding a comment) of HeapIterator.

5 years, 3 months ago (2015-08-27 14:01:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319953003/20001

5 years, 3 months ago (2015-08-27 14:21:47 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-08-27 14:56:27 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/5d3f801a463df6644e26f709db691d44469643c8
Cr-Commit-Position: refs/heads/master@{#30418}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages