Stop infinite recursion when generating anonymous table boxes

Stop infinite recursion when generating anonymous table boxes

Update the list of box types to expect directly inside (anonymous) table
boxes to include 'table-column' (in addition to 'table-column-group'
and 'table-caption'.)  This fixes the code that looks for an existing
anonymous table section to add a child to so that it doesn't accidentally
try to add the child to the same table box again recursively.

Also drop a couple of lines of code that had no effect in practice.

BUG=330651
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165216

[Jens Widell, 2014-01-09 16:13:58]

Hi Julien,

could you take a look at this patch?

[Julien - ping for review, 2014-01-14 02:05:56]

The code change is fine but it's missing a test case: the bug has a test case
attached to it which should be included after improving it.

[Jens Widell, 2014-01-14 09:02:25]

On 2014/01/14 02:05:56, Julien Chaffraix - PST wrote:
> The code change is fine but it's missing a test case: the bug has a test case
> attached to it which should be included after improving it.

Test case added.

It seems that a release build doesn't necessarily crash, but might rather hang
indefinitely.  I guess an optimizing compiler can rather easily apply a tail
recursion optimization that transforms the problem into a simple never-ending
loop.

[Julien - ping for review, 2014-01-15 17:30:20]

lgtm

https://codereview.chromium.org/131993002/diff/70001/LayoutTests/fast/table/c...
File LayoutTests/fast/table/crash-col-in-anonymous-table.html (right):

https://codereview.chromium.org/131993002/diff/70001/LayoutTests/fast/table/c...
LayoutTests/fast/table/crash-col-in-anonymous-table.html:19: <div>This test
passes if it does not CRASH.</div>
Nit: You can say CRASH or HANG as you mentioned we can have either behavior.

[Jens Widell, 2014-01-15 17:44:18]

On 2014/01/15 17:30:20, Julien Chaffraix - PST wrote:
> lgtm

Thanks!

>
https://codereview.chromium.org/131993002/diff/70001/LayoutTests/fast/table/c...
> File LayoutTests/fast/table/crash-col-in-anonymous-table.html (right):
> 
>
https://codereview.chromium.org/131993002/diff/70001/LayoutTests/fast/table/c...
> LayoutTests/fast/table/crash-col-in-anonymous-table.html:19: <div>This test
> passes if it does not CRASH.</div>
> Nit: You can say CRASH or HANG as you mentioned we can have either behavior.

Updated the test to say "CRASH or HANG".

[Julien - ping for review, 2014-01-15 19:21:43]

https://codereview.chromium.org/131993002/diff/170001/LayoutTests/fast/table/...
File LayoutTests/fast/table/crash-col-in-anonymous-table-expected.txt (right):

https://codereview.chromium.org/131993002/diff/170001/LayoutTests/fast/table/...
LayoutTests/fast/table/crash-col-in-anonymous-table-expected.txt:2: This test
passes if it does not CRASH.
You forgot to update the baseline, the cq will reject your patch because of that
:)

[Jens Widell, 2014-01-15 19:36:44]

https://codereview.chromium.org/131993002/diff/170001/LayoutTests/fast/table/...
File LayoutTests/fast/table/crash-col-in-anonymous-table-expected.txt (right):

https://codereview.chromium.org/131993002/diff/170001/LayoutTests/fast/table/...
LayoutTests/fast/table/crash-col-in-anonymous-table-expected.txt:2: This test
passes if it does not CRASH.
On 2014/01/15 19:21:43, Julien Chaffraix - PST wrote:
> You forgot to update the baseline, the cq will reject your patch because of
that
> :)

Silly me. :-) Fixed now.

[commit-bot: I haz the power, 2014-01-16 06:12:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jl@opera.com/131993002/230001

[commit-bot: I haz the power, 2014-01-16 07:25:49]

Retried try job too often on linux_blink for step(s) wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-16 12:33:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jl@opera.com/131993002/230001

[commit-bot: I haz the power, 2014-01-16 12:43:40]

Change committed as 165216