Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: src/runtime.js

Issue 1319893004: Remove builtin/runtime name clash presubmit check. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parser.cc ('k') | tools/check-name-clashes.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.js
diff --git a/src/runtime.js b/src/runtime.js
index bbffef268b093d365b739601cb28e42d94d1a252..1503373d4a3fc6c78cc2630b039800f30c338b08 100644
--- a/src/runtime.js
+++ b/src/runtime.js
@@ -63,7 +63,9 @@ function EQUALS(y) {
while (true) {
if (IS_STRING(y)) return %StringEquals(x, y);
if (IS_NUMBER(y)) return %NumberEquals(%to_number_fun(x), y);
- if (IS_BOOLEAN(y)) return %NumberEquals(%to_number_fun(x), %to_number_fun(y));
+ if (IS_BOOLEAN(y)) {
+ return %NumberEquals(%to_number_fun(x), %to_number_fun(y));
+ }
if (IS_NULL_OR_UNDEFINED(y)) return 1; // not equal
if (IS_SYMBOL(y) || IS_SIMD_VALUE(y)) return 1; // not equal
y = %to_primitive(y, NO_HINT);
@@ -75,7 +77,9 @@ function EQUALS(y) {
if (IS_BOOLEAN(y)) return %_ObjectEquals(x, y) ? 0 : 1;
if (IS_NULL_OR_UNDEFINED(y)) return 1;
if (IS_NUMBER(y)) return %NumberEquals(%to_number_fun(x), y);
- if (IS_STRING(y)) return %NumberEquals(%to_number_fun(x), %to_number_fun(y));
+ if (IS_STRING(y)) {
+ return %NumberEquals(%to_number_fun(x), %to_number_fun(y));
+ }
if (IS_SYMBOL(y) || IS_SIMD_VALUE(y)) return 1; // not equal
// y is object.
x = %to_number_fun(x);
« no previous file with comments | « src/parser.cc ('k') | tools/check-name-clashes.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698