Source/web/tests/FrameTestHelpers.cpp - Issue 1319863006: (blink) Propagate scrolling/marginwidth/marginheight property values to child frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/FrameTestHelpers.cpp

Issue 1319863006: (blink) Propagate scrolling/marginwidth/marginheight property values to child frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: address comments + static_cast for enum conversion Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/FrameTestHelpers.cpp

diff --git a/Source/web/tests/FrameTestHelpers.cpp b/Source/web/tests/FrameTestHelpers.cpp

index 62232f33dfd0534703f96db2701ae80f44a7113d..e78814444cfdbd79b9ac12655021d0418bae791a 100644

--- a/Source/web/tests/FrameTestHelpers.cpp

+++ b/Source/web/tests/FrameTestHelpers.cpp

@@ -286,7 +286,7 @@ TestWebFrameClient::TestWebFrameClient() : m_loadsInProgress(0)

{

}

-WebFrame* TestWebFrameClient::createChildFrame(WebLocalFrame* parent, WebTreeScopeType scope, const WebString& frameName, WebSandboxFlags sandboxFlags)

+WebFrame* TestWebFrameClient::createChildFrame(WebLocalFrame* parent, WebTreeScopeType scope, const WebString& frameName, WebSandboxFlags sandboxFlags, const WebFrameOwnerProperties& frameOwnerProperties)

{

WebFrame* frame = WebLocalFrame::create(scope, this);

parent->appendChild(frame);

« Source/web/WebLocalFrameImpl.cpp ('K') | « Source/web/tests/FrameTestHelpers.h ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | public/web/WebFrameClient.h » ('J')