(blink) Propagate scrolling/marginwidth/marginheight property values to child frame.

public/web/WebFrameClient.h

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 #ifndef WebFrameClient_h
 #define WebFrameClient_h
 
 #include "../platform/WebColor.h"
 #include "WebAXObject.h"
 #include "WebDOMMessageEvent.h"
 #include "WebDataSource.h"
 #include "WebFrame.h"
+#include "WebFrameOwnerProperties.h"
 #include "WebHistoryCommitType.h"
 #include "WebHistoryItem.h"
 #include "WebIconURL.h"
 #include "WebNavigationPolicy.h"
 #include "WebNavigationType.h"
 #include "WebNavigatorContentUtilsClient.h"
 #include "WebSandboxFlags.h"
 #include "WebTextDirection.h"
 #include "public/platform/WebCommon.h"
 #include "public/platform/WebFileSystem.h"
@@ skipping 93 matching lines @@
     // document of a main frame. After this, it is no longer safe to show a
     // pending navigation's URL, because a URL spoof is possible.
     virtual void didAccessInitialDocument(WebLocalFrame*) { }
 
     // A child frame was created in this frame. This is called when the frame
     // is created and initialized. Takes the name of the new frame, the parent
     // frame and returns a new WebFrame. The WebFrame is considered in-use
     // until frameDetached() is called on it.
     // Note: If you override this, you should almost certainly be overriding
     // frameDetached().
-    virtual WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, WebSandboxFlags sandboxFlags) { return nullptr; }
+    virtual WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, WebSandboxFlags sandboxFlags, const WebFrameOwnerProperties&) { return nullptr; }

[alexmos, 2015/09/02 21:37:06]

Changing this signature was "fun" the last time I did it...  Don't forget to
update the createChildFrame in 
android_webview/renderer/print_web_view_helper.cc and
mojo/services/html_viewer/html_document.cc on the chromium side to avoid
breaking Android and mojo.  And presumably you'll add a temp version of this
with the old signature so you can land this independently?

[lazyboy, 2015/09/15 01:40:33]

This probably moved to components/printing/renderer/print_web_view_helper.cc
now, right?
and
Done.
And presumably you'll add a temp version of this
Yes, I'll do that once the CL gets close to be completed and I have tests.

[alexmos, 2015/09/16 00:36:47]

Yes, looks like it.

 
     // This frame set its opener to null, disowning it.
     // See http://html.spec.whatwg.org/#dom-opener.
     // TODO(alexmos): Remove this once didChangeOpener is implemented in content.
     virtual void didDisownOpener(WebLocalFrame*) { }
 
     // This frame has set its opener to another frame, or disowned the opener
     // if opener is null. See http://html.spec.whatwg.org/#dom-opener.
     virtual void didChangeOpener(WebFrame*) { }
 
     // Specifies the reason for the detachment.
     enum class DetachType { Remove, Swap };
 
     // This frame has been detached from the view, but has not been closed yet.
     virtual void frameDetached(WebFrame*, DetachType) { }
 
     // This frame has become focused..
     virtual void frameFocused() { }
 
     // This frame is about to be closed. This is called after frameDetached,
     // when the document is being unloaded, due to new one committing.
     virtual void willClose(WebFrame*) { }
 
     // This frame's name has changed.
     virtual void didChangeName(WebLocalFrame*, const WebString&) { }
 
     // The sandbox flags have changed for a child frame of this frame.
     virtual void didChangeSandboxFlags(WebFrame* childFrame, WebSandboxFlags flags) { }
 
+    // The "marginwidth" property has changed for a child frame of this frame.
+    virtual void didChangeMarginWidth(WebFrame* childFrame, int newMarginWidth) {}
+
+    // The "marginheight" property has changed for a child frame of this frame.
+    virtual void didChangeMarginHeight(WebFrame* childFrame, int newMarginHeight) {}
+
+    // The "scrolling" property has changed for a child frame of this frame.
+    virtual void didChangeScrollingMode(WebFrame* childFrame, WebFrameOwnerProperties::ScrollingMode) {}
+
     // Called when a watched CSS selector matches or stops matching.
     virtual void didMatchCSS(WebLocalFrame*, const WebVector<WebString>& newlyMatchingSelectors, const WebVector<WebString>& stoppedMatchingSelectors) { }
 
 
     // Console messages ----------------------------------------------------
 
     // Whether or not we should report a detailed message for the given source.
     virtual bool shouldReportDetailedMessageForSource(const WebString& source) { return false; }
 
     // A new message was added to the console.
@@ skipping 481 matching lines @@
     // WebUSB --------------------------------------------------------------
     virtual WebUSBClient* usbClient() { return nullptr; }
 
 protected:
     virtual ~WebFrameClient() { }
 };
 
 } // namespace blink
 
 #endif