(blink) Propagate scrolling/marginwidth/marginheight property values to child frame.

Source/web/WebLocalFrameImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 182 matching lines @@
 #include "public/platform/WebSuspendableTask.h"
 #include "public/platform/WebURLError.h"
 #include "public/platform/WebVector.h"
 #include "public/web/WebAutofillClient.h"
 #include "public/web/WebConsoleMessage.h"
 #include "public/web/WebDOMEvent.h"
 #include "public/web/WebDocument.h"
 #include "public/web/WebFindOptions.h"
 #include "public/web/WebFormElement.h"
 #include "public/web/WebFrameClient.h"
+#include "public/web/WebFrameOwnerProperties.h"
 #include "public/web/WebHistoryItem.h"
 #include "public/web/WebIconURL.h"
 #include "public/web/WebInputElement.h"
 #include "public/web/WebKit.h"
 #include "public/web/WebNode.h"
 #include "public/web/WebPerformance.h"
 #include "public/web/WebPlugin.h"
 #include "public/web/WebPrintParams.h"
 #include "public/web/WebPrintPresetOptions.h"
 #include "public/web/WebRange.h"
@@ skipping 1534 matching lines @@
     return frame;
 }
 
 PassRefPtrWillBeRawPtr<LocalFrame> WebLocalFrameImpl::createChildFrame(const FrameLoadRequest& request,
     const AtomicString& name, HTMLFrameOwnerElement* ownerElement)
 {
     ASSERT(m_client);
     WebTreeScopeType scope = frame()->document() == ownerElement->treeScope()
         ? WebTreeScopeType::Document
         : WebTreeScopeType::Shadow;
-    WebLocalFrameImpl* webframeChild = toWebLocalFrameImpl(m_client->createChildFrame(this, scope, name, static_cast<WebSandboxFlags>(ownerElement->sandboxFlags())));
+    int marginWidth = -1;
+    int marginHeight = -1;
+    if (isHTMLFrameElementBase(ownerElement)) {
+        marginWidth = toHTMLFrameElementBase(ownerElement)->marginWidth();

[alexmos, 2015/09/02 21:37:06]

Is the cast necessary here?  marginWidth() and marginHeight() exist on
HTMLFrameOwnerElement.  Also see my earlier question about whether this needs to
be guarded by isHTMLFrameElementBase.

[lazyboy, 2015/09/15 01:40:33]

Removed cast.
Also see my earlier question about whether this needs to
The caller of this function is FrameLoaderClientImpl::createFrame(), which
shouldn't be called for a plugin, right? I was inspired by looking at the
comment in WebLocalFrameImpl::fromFrameOwnerElement().

[alexmos, 2015/09/16 00:36:47]

I think you're right, we shouldn't get here for plugins (assuming plugins can't
create subframes:) ).  So then we don't need the isHTMLFrameElementBase check,
right?

[alexmos, 2015/09/21 16:58:07]

Latest PS still has isHTMLFrameElementBase check - did you want to remove it,
since we shouldn't get here for plugins?

[lazyboy, 2015/09/21 18:04:51]

Removed.

+        marginHeight = toHTMLFrameElementBase(ownerElement)->marginHeight();
+    }
+
+    WebFrameOwnerProperties ownerProperties(static_cast<WebFrameOwnerProperties::ScrollingMode>(ownerElement->scrollingMode()), marginWidth, marginHeight);
+    WebLocalFrameImpl* webframeChild = toWebLocalFrameImpl(m_client->createChildFrame(this, scope, name, static_cast<WebSandboxFlags>(ownerElement->sandboxFlags()), ownerProperties));
     if (!webframeChild)
         return nullptr;
 
     // FIXME: Using subResourceAttributeName as fallback is not a perfect
     // solution. subResourceAttributeName returns just one attribute name. The
     // element might not have the attribute, and there might be other attributes
     // which can identify the element.
     RefPtrWillBeRawPtr<LocalFrame> child = webframeChild->initializeCoreFrame(frame()->host(), ownerElement, name, ownerElement->getAttribute(ownerElement->subResourceAttributeName()));
     // Initializing the core frame may cause the new child to be detached, since
     // it may dispatch a load event in the parent.
@@ skipping 428 matching lines @@
 }
 
 WebSandboxFlags WebLocalFrameImpl::effectiveSandboxFlags() const
 {
     if (!frame())
         return WebSandboxFlags::None;
     return static_cast<WebSandboxFlags>(frame()->loader().effectiveSandboxFlags());
 }
 
 } // namespace blink