Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1319843002: [turbofan] LiveRange splintering optimizations. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] LiveRange splintering optimizations. Related to 1318893002 - another source of regressions in benchmarks sensitive to compile time is the splintering logic. This change addresses some, but not all, of that. In particular, there are still some places (figuring out if a range has a hole right where a deferred set of blocks is) that need another look. BUG=chromium:524880 LOG=n Committed: https://crrev.com/2ba2f40c6a331111361585289ecf137ff98b02c7 Cr-Commit-Position: refs/heads/master@{#30425}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -37 lines) Patch
M src/compiler/live-range-separator.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 4 chunks +42 lines, -33 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mircea Trofin
5 years, 3 months ago (2015-08-27 01:03:57 UTC) #2
Benedikt Meurer
LGTM once out of bounds crashers are resolved.
5 years, 3 months ago (2015-08-27 04:40:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319843002/20001
5 years, 3 months ago (2015-08-27 18:27:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-27 18:28:27 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 18:28:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ba2f40c6a331111361585289ecf137ff98b02c7
Cr-Commit-Position: refs/heads/master@{#30425}

Powered by Google App Engine
This is Rietveld 408576698