[Interpreter] Add support for property store operations.

[Interpreter] Add support for property store operations.

Adds support for property store operations via Store/KeyedStore ICs. Adds the
following bytecodes:
 - StoreIC
 - KeyedStoreIC

The --vector_store flag is now required for --ignition.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/23f7d34d4283b470f82c7ef485cc95e7e84106fe
Cr-Commit-Position: refs/heads/master@{#30660}

[rmcilroy, 2015-09-07 23:30:54]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-07 23:31:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1319833004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1319833004/1

[commit-bot: I haz the power, 2015-09-07 23:56:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-07 23:56:19]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2015-09-08 08:21:04]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org, mvstanton@chromium.org, oth@chromium.org

[rmcilroy, 2015-09-08 08:21:05]

Michi / Orion, please review interpreter parts
Michael for vector stuff.
Thanks!

[mvstanton, 2015-09-08 19:46:45]

Ah, you can ignore my comment about SLOPPY/STRICT because I see elsewhere that
you are only handling SLOPPY for now.

Nice tests, again!

LGTM.

https://codereview.chromium.org/1319833004/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/1319833004/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:256:
CodeFactory::StoreICInOptimizedCode(isolate_, SLOPPY, UNINITIALIZED);
Don't you need to pick up SLOPPY or STRICT from elsewhere?

https://codereview.chromium.org/1319833004/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:267:
CodeFactory::KeyedStoreICInOptimizedCode(isolate_, SLOPPY, UNINITIALIZED);
Same here...

[Michael Starzinger, 2015-09-09 10:33:01]

LGTM.

[rmcilroy, 2015-09-09 14:22:01]

> Ah, you can ignore my comment about SLOPPY/STRICT because I see elsewhere that
> you are only handling SLOPPY for now.

Yes, we only handle SLOPPY mode for now. As discussed offline we will probably
have to have Strict/Strong versions of these bytecodes, but I'll do that in a
future CL. Thanks for the reviews.

[oth, 2015-09-09 14:37:29]

lgtm. minor comment, but great.

https://codereview.chromium.org/1319833004/diff/1/src/interpreter/bytecodes.h
File src/interpreter/bytecodes.h (right):

https://codereview.chromium.org/1319833004/diff/1/src/interpreter/bytecodes.h...
src/interpreter/bytecodes.h:101: int index() const { return index_; }
Could fail fast here - DCHECK(is_valid(index())).

[rmcilroy, 2015-09-09 15:18:57]

https://codereview.chromium.org/1319833004/diff/1/src/interpreter/bytecodes.h
File src/interpreter/bytecodes.h (right):

https://codereview.chromium.org/1319833004/diff/1/src/interpreter/bytecodes.h...
src/interpreter/bytecodes.h:101: int index() const { return index_; }
On 2015/09/09 14:37:29, oth wrote:
> Could fail fast here - DCHECK(is_valid(index())).

Done.

[rmcilroy, 2015-09-09 15:19:20]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-09-09 15:19:21]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org,
mvstanton@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1319833004/#ps20001
(title: "Add DCHECK")

[commit-bot: I haz the power, 2015-09-09 15:19:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1319833004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1319833004/20001

[commit-bot: I haz the power, 2015-09-09 15:46:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-09 15:46:18]

Patchset 2 (id:??) landed as
https://crrev.com/23f7d34d4283b470f82c7ef485cc95e7e84106fe
Cr-Commit-Position: refs/heads/master@{#30660}