Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1319823002: Devtools Color: Animate drag rearrangement of custom color palette (Closed)

Created:
5 years, 3 months ago by samli
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools Color: Animate drag rearrangement of custom color palette BUG=461320 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201273

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Improve performance #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M Source/devtools/front_end/elements/Spectrum.js View 1 2 3 chunks +19 lines, -8 lines 0 comments Download
M Source/devtools/front_end/elements/spectrum.css View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
samli
https://codereview.chromium.org/1319823002/diff/1/Source/devtools/front_end/elements/spectrum.css File Source/devtools/front_end/elements/spectrum.css (right): https://codereview.chromium.org/1319823002/diff/1/Source/devtools/front_end/elements/spectrum.css#newcode214 Source/devtools/front_end/elements/spectrum.css:214: border: 1px solid #ddd; This is used in the ...
5 years, 3 months ago (2015-08-26 22:08:37 UTC) #2
pfeldman
lgtm
5 years, 3 months ago (2015-08-26 23:24:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319823002/40001
5 years, 3 months ago (2015-08-26 23:27:47 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 01:02:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201273

Powered by Google App Engine
This is Rietveld 408576698