Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: media/formats/mp4/mp4_stream_parser.cc

Issue 1319813002: Fix mp4 keyframe parsing, removing unused stss parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix sizeof nit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/formats/mp4/box_definitions.cc ('k') | media/formats/mp4/track_run_iterator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/mp4_stream_parser.cc
diff --git a/media/formats/mp4/mp4_stream_parser.cc b/media/formats/mp4/mp4_stream_parser.cc
index 8f4a2284346298afa54f4137aa40955df3dcbc8c..3cad03d4649f894a4cfd54f36b742618c6e45553 100644
--- a/media/formats/mp4/mp4_stream_parser.cc
+++ b/media/formats/mp4/mp4_stream_parser.cc
@@ -516,12 +516,9 @@ bool MP4StreamParser::EnqueueSample(BufferQueue* audio_buffers,
// TODO(wolenetz/acolwell): Validate and use a common cross-parser TrackId
// type and allow multiple tracks for same media type, if applicable. See
// https://crbug.com/341581.
- //
- // NOTE: MPEG's "random access point" concept is equivalent to the
- // downstream code's "is keyframe" concept.
scoped_refptr<StreamParserBuffer> stream_buf =
StreamParserBuffer::CopyFrom(&frame_buf[0], frame_buf.size(),
- runs_->is_random_access_point(),
+ runs_->is_keyframe(),
buffer_type, 0);
if (decrypt_config)
@@ -533,7 +530,6 @@ bool MP4StreamParser::EnqueueSample(BufferQueue* audio_buffers,
DVLOG(3) << "Pushing frame: aud=" << audio
<< ", key=" << runs_->is_keyframe()
- << ", rap=" << runs_->is_random_access_point()
<< ", dur=" << runs_->duration().InMilliseconds()
<< ", dts=" << runs_->dts().InMilliseconds()
<< ", cts=" << runs_->cts().InMilliseconds()
« no previous file with comments | « media/formats/mp4/box_definitions.cc ('k') | media/formats/mp4/track_run_iterator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698