Remove the chrome include in extensions\DEPS by creating a test data directory for extensions.

Remove the chrome include in extensions\DEPS by creating a test data directory for extensions.

BUG=159265
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191253

[jam, 2013-03-28 17:39:38]

small cleanup. In my experience, best to avoid any chrome includes or more
dependencies will creep in.

btw Rietveld doesn't show it, but I also created extensions\test\data now which
is empty.

[jam, 2013-03-28 18:12:11]

On 2013/03/28 17:39:38, jam wrote:
> btw Rietveld doesn't show it, but I also created extensions\test\data now
which
> is empty.

fyi this is why the unittest is failing, since the empty new directory isn't
being created by the apply_issue step. it does pass locally, and will do so on
the bots when this is committed.

[Yoyo Zhou, 2013-03-28 18:14:44]

On 2013/03/28 17:39:38, jam wrote:
> small cleanup. In my experience, best to avoid any chrome includes or more
> dependencies will creep in.
> 
> btw Rietveld doesn't show it, but I also created extensions\test\data now
which
> is empty.

If these tests now expect the test data to be in extensions/test/data instead of
chrome/test/data, then their test data needs to be moved there, right?

(I'm confused about why the FileReader tests are still passing.)

[jam, 2013-03-28 18:24:06]

On 2013/03/28 18:14:44, Yoyo Zhou wrote:
> On 2013/03/28 17:39:38, jam wrote:
> > small cleanup. In my experience, best to avoid any chrome includes or more
> > dependencies will creep in.
> > 
> > btw Rietveld doesn't show it, but I also created extensions\test\data now
> which
> > is empty.
> 
> If these tests now expect the test data to be in extensions/test/data instead
of
> chrome/test/data, then their test data needs to be moved there, right?
> 
> (I'm confused about why the FileReader tests are still passing.)

ah, good point. Looks like the tests, as written, would pass without the data.

I committed the data now in a separate commit (r191177) since otherwise the
tryjobs would fail, and updated the cl.

[Yoyo Zhou, 2013-03-28 18:30:03]

LGTM

[jam, 2013-03-28 20:29:02]

Yoyo: I made a small change to the gypi file so that these tests don't run on
Android where enable_extensions==0. This was needed since the phones don't
checkout src/extensions/test/data. While I could have made them do that, it
seemed pointless since they don't care about extensions.

[Yoyo Zhou, 2013-03-28 20:33:13]

On 2013/03/28 20:29:02, jam wrote:
> Yoyo: I made a small change to the gypi file so that these tests don't run on
> Android where enable_extensions==0. This was needed since the phones don't
> checkout src/extensions/test/data. While I could have made them do that, it
> seemed pointless since they don't care about extensions.

Ok, still LGTM.